Update testing tools (AppRTC, Go) to new versions

Update testing tools (AppRTC, Go) to new versions

App engine is included in the AppRTC archive, so the separate archive is not needed anymore.
Mercurial is no longer necessary to include but it will be required during the vendoring step when the prebuilt archives are update.

The download/build scripts have been simplified accordingly.

The video quality test has been updated to work with the new appengine.

BUG=webrtc:7602
Review-Url: https://codereview.webrtc.org/2882073003
Cr-Commit-Position: refs/heads/master@{#18162}
Committed: https://chromium.googlesource.com/external/webrtc/+/1d7392a45c95794b385f6a7c3a9dfa5428c4bbed

[oprypin_webrtc, 2017-05-15 13:56:17]

Patchset #1 (id:1) has been deleted

[oprypin_webrtc, 2017-05-15 14:08:14]

Description was changed from

==========
Update testing tools (AppRTC, Go) to new versions

BUG=
==========

to

==========
Update testing tools (AppRTC, Go) to new versions

BUG=webrtc:7602
==========

[oprypin_webrtc, 2017-05-15 14:08:56]

oprypin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-05-15 20:19:55]

LGTM with comments addressed.
Great you were able to get rid of Mercurial

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
File webrtc/tools/testing/build_apprtc.py (right):

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
webrtc/tools/testing/build_apprtc.py:12: The golang toolchain is downloaded by
download_golang.py. We use that here
This is no longer true, needs update.

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
webrtc/tools/testing/build_apprtc.py:15: This script needs to know the path to
the 'src' directory in apprtc, the
This seems to need an update as well.

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
webrtc/tools/testing/build_apprtc.py:50: golang_env['GOPATH'] = golang_workspace
Are the new Go packages prepared with some extra change to bundle the
golang.org/x/net/websocket dependency? If so, we should have instructions on how
to update them (preferably in a README.md file here, but it could also go
somewhere else).

[oprypin_webrtc, 2017-05-16 09:13:28]

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
File webrtc/tools/testing/build_apprtc.py (right):

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
webrtc/tools/testing/build_apprtc.py:12: The golang toolchain is downloaded by
download_golang.py. We use that here
On 2017/05/15 20:19:55, kjellander_webrtc wrote:
> This is no longer true, needs update.

Done.

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
webrtc/tools/testing/build_apprtc.py:15: This script needs to know the path to
the 'src' directory in apprtc, the
On 2017/05/15 20:19:54, kjellander_webrtc wrote:
> This seems to need an update as well.

Done.

https://codereview.webrtc.org/2882073003/diff/40001/webrtc/tools/testing/buil...
webrtc/tools/testing/build_apprtc.py:50: golang_env['GOPATH'] = golang_workspace
On 2017/05/15 20:19:54, kjellander_webrtc wrote:
> Are the new Go packages prepared with some extra change to bundle the
> golang.org/x/net/websocket dependency? If so, we should have instructions on
how
> to update them (preferably in a README.md file here, but it could also go
> somewhere else).

Done.

[kjellander_webrtc, 2017-05-16 09:20:10]

lgtm % my question about golang.org/x/net/websocket

https://codereview.webrtc.org/2882073003/diff/100001/webrtc/tools/testing/REA...
File webrtc/tools/testing/README.md (right):

https://codereview.webrtc.org/2882073003/diff/100001/webrtc/tools/testing/REA...
webrtc/tools/testing/README.md:31: - go*.windows-amd64.zip ->
golang/windows/go.zip
Wasn't there a step to avoid having to run 'go get' in order to download the
golang.org/x/net/websocket dependency?

[oprypin_webrtc, 2017-05-16 09:24:11]

https://codereview.webrtc.org/2882073003/diff/100001/webrtc/tools/testing/REA...
File webrtc/tools/testing/README.md (right):

https://codereview.webrtc.org/2882073003/diff/100001/webrtc/tools/testing/REA...
webrtc/tools/testing/README.md:31: - go*.windows-amd64.zip ->
golang/windows/go.zip
On 2017/05/16 09:20:10, kjellander_webrtc wrote:
> Wasn't there a step to avoid having to run 'go get' in order to download the
> golang.org/x/net/websocket dependency?

The addition of "Vendor collider's dependencies:" to the archivation process is
making it so we don't have to run `go get` during every test run. We cannot get
rid of the step entirely, we can only move it here.

[oprypin_webrtc, 2017-05-16 09:44:11]

Description was changed from

==========
Update testing tools (AppRTC, Go) to new versions

BUG=webrtc:7602
==========

to

==========
Update testing tools (AppRTC, Go) to new versions

App engine is included in the AppRTC archive, so the separate archive is not
needed anymore.
Mercurial is no longer necessary to include but it will be required during the
vendoring step when the prebuilt archives are update.

The download/build scripts have been simplified accordingly.

The video quality test has been updated to work with the new appengine.

BUG=webrtc:7602
==========

[oprypin_webrtc, 2017-05-16 10:53:50]

oprypin@webrtc.org changed reviewers:
+ mbonadei@webrtc.org

[mbonadei, 2017-05-16 11:50:06]

lgtm

[oprypin_webrtc, 2017-05-16 12:18:20]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-05-16 12:18:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-16 12:36:17]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494937100568490,
"parent_rev": "b3b2a8f42467886c7874fd0766e824b1c6632a87", "commit_rev":
"1d7392a45c95794b385f6a7c3a9dfa5428c4bbed"}

[commit-bot: I haz the power, 2017-05-16 12:36:21]

Description was changed from

==========
Update testing tools (AppRTC, Go) to new versions

App engine is included in the AppRTC archive, so the separate archive is not
needed anymore.
Mercurial is no longer necessary to include but it will be required during the
vendoring step when the prebuilt archives are update.

The download/build scripts have been simplified accordingly.

The video quality test has been updated to work with the new appengine.

BUG=webrtc:7602
==========

to

==========
Update testing tools (AppRTC, Go) to new versions

App engine is included in the AppRTC archive, so the separate archive is not
needed anymore.
Mercurial is no longer necessary to include but it will be required during the
vendoring step when the prebuilt archives are update.

The download/build scripts have been simplified accordingly.

The video quality test has been updated to work with the new appengine.

BUG=webrtc:7602

Review-Url: https://codereview.webrtc.org/2882073003
Cr-Commit-Position: refs/heads/master@{#18162}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1d7392a45c95794b385f6a7c3...
==========

[commit-bot: I haz the power, 2017-05-16 12:36:22]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/1d7392a45c95794b385f6a7c3...