Update testing tools (AppRTC, Go) to new versions

webrtc/tools/testing/build_apprtc.py

 #!/usr/bin/env python
 # Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 """Builds the AppRTC collider using the golang toolchain.
 
 The golang toolchain is downloaded by download_golang.py. We use that here

[kjellander_webrtc, 2017/05/15 20:19:55]

This is no longer true, needs update.

[oprypin_webrtc, 2017/05/16 09:13:28]

Done.

 to build the AppRTC collider server.
 
 This script needs to know the path to the 'src' directory in apprtc, the

[kjellander_webrtc, 2017/05/15 20:19:54]

This seems to need an update as well.

[oprypin_webrtc, 2017/05/16 09:13:27]

Done.

 root directory of 'go', the root directory of 'hg' and the output_dir.
 """
 
 import os
 import shutil
 import subprocess
 import sys
 
 import utils
 
 
-USAGE_STR = "Usage: {} <apprtc_src_dir> <go_dir> <hg_dir> <output_dir>"
+USAGE_STR = "Usage: {} <apprtc_src_dir> <go_dir> <output_dir>"
 
 
 def main(argv):
-  if len(argv) != 5:
+  if len(argv) != 4:
     return USAGE_STR.format(argv[0])
 
-  apprtc_dir = argv[1]
-  go_root_dir = argv[2]
-  mercurial_dir = argv[3]
-  golang_workspace = argv[4]
+  apprtc_dir = os.path.abspath(argv[1])
+  go_root_dir = os.path.abspath(argv[2])
+  golang_workspace = os.path.abspath(argv[3])
 
   utils.RemoveDirectory(golang_workspace)
 
   golang_workspace_src = os.path.join(golang_workspace, 'src')
 
   collider_dir = os.path.join(apprtc_dir, 'collider')
-  shutil.copytree(collider_dir, golang_workspace_src,
-                  ignore=shutil.ignore_patterns('.svn', '.git'))
+  shutil.copytree(collider_dir, golang_workspace_src)
 
   golang_binary = 'go%s' % ('.exe' if utils.GetPlatform() == 'win' else '')
   golang_path = os.path.join(go_root_dir, 'bin', golang_binary)
 
   golang_env = os.environ.copy()
   golang_env['GOROOT'] = go_root_dir
-  golang_env['GOPATH'] = os.path.abspath(golang_workspace)
-  golang_env['PATH'] += os.pathsep + mercurial_dir
-  subprocess.check_call([golang_path, 'get', 'collidermain'],
-                        env=golang_env)
+  golang_env['GOPATH'] = golang_workspace

[kjellander_webrtc, 2017/05/15 20:19:54]

Are the new Go packages prepared with some extra change to bundle the
golang.org/x/net/websocket dependency? If so, we should have instructions on how
to update them (preferably in a README.md file here, but it could also go
somewhere else).

[oprypin_webrtc, 2017/05/16 09:13:27]

Done.

   collider_exec = os.path.join(golang_workspace, 'collidermain')
   subprocess.check_call([golang_path, 'build', '-o', collider_exec,
                          'collidermain'], env=golang_env)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))