Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2872303003: Supporting orphan headers check on ios_framework_bundle (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Supporting orphan headers check on ios_framework_bundle ios_framework_bundle does not have 'sources' but 'common_objc_headers' and it was causins a couple of false positives. BUG=webrtc:7514 NOTRY=True Review-Url: https://codereview.webrtc.org/2872303003 Cr-Commit-Position: refs/heads/master@{#18084} Committed: https://chromium.googlesource.com/external/webrtc/+/84ab581e0bc68a3b1c13c59e87a5901a1c94d617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools_webrtc/presubmit_checks_lib/check_orphan_headers.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mbonadei
3 years, 7 months ago (2017-05-10 13:38:36 UTC) #2
kjellander_webrtc
lgtm
3 years, 7 months ago (2017-05-10 14:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2872303003/1
3 years, 7 months ago (2017-05-10 15:01:43 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:04:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/84ab581e0bc68a3b1c13c59e8...

Powered by Google App Engine
This is Rietveld 408576698