tools_webrtc/presubmit_checks_lib/check_orphan_headers.py - Issue 2872303003: Supporting orphan headers check on ios_framework_bundle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools_webrtc/presubmit_checks_lib/check_orphan_headers.py

Issue 2872303003: Supporting orphan headers check on ios_framework_bundle (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools_webrtc/presubmit_checks_lib/check_orphan_headers.py

diff --git a/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py b/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py

index 707c49fcc5347a3bc83257b0ff7d31cb9b90a34c..6c14aad2a4ce69b53c88cfcb4b4165fbe43f70ec 100644

--- a/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py

+++ b/tools_webrtc/presubmit_checks_lib/check_orphan_headers.py

@@ -18,8 +18,9 @@ TARGET_RE = re.compile(r'(?P<indent>\s*)\w+\("(?P<target_name>\w+)"\) {'

re.MULTILINE | re.DOTALL)

# SOURCES_RE matches a block of sources inside a GN target.

-SOURCES_RE = re.compile(r'sources \+?= \[(?P<sources>.*?)\]',

- re.MULTILINE | re.DOTALL)

+SOURCES_RE = re.compile(

+ r'(sources|common_objc_headers) \+?= \[(?P<sources>.*?)\]',

+ re.MULTILINE | re.DOTALL)

SOURCE_FILE_RE = re.compile(r'.*\"(?P<source_file>.*)\"')

« no previous file with comments | « no previous file | no next file » | no next file with comments »