Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Also, move the --timeout=900 flag from the recipe to the mb.py script. That way it is passed as an arg to gtest-parallel and not to the test executable.

BUG=webrtc:7568
NOTRY=True

Review-Url: https://codereview.webrtc.org/2862803002
Cr-Commit-Position: refs/heads/master@{#18015}
Committed: https://chromium.googlesource.com/external/webrtc/+/76e60e928f8f96c9d8686b0637952125a5f2649c

[ehmaldonado_webrtc, 2017-05-04 09:11:31]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 09:11:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ehmaldonado_webrtc, 2017-05-04 09:12:00]

Description was changed from

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

BUG=chromium:718339
==========

to

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

BUG=webrtc:7568
==========

[ehmaldonado_webrtc, 2017-05-04 09:12:51]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2017-05-04 09:16:14]

Can we move the --timeout=900 flag from 
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/st...

To somewhere around here
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/mb/mb...

So that the flag is not passed to the test, but to the gtest-parallel-wrapper.py
script?

[kjellander_webrtc, 2017-05-04 09:30:06]

Nice! Please just fix some of the docs

https://codereview.webrtc.org/2862803002/diff/1/tools-webrtc/gtest-parallel-w...
File tools-webrtc/gtest-parallel-wrapper.py (left):

https://codereview.webrtc.org/2862803002/diff/1/tools-webrtc/gtest-parallel-w...
tools-webrtc/gtest-parallel-wrapper.py:21: Note that the flags unprocessed by
this script will passed as arguments to the
I think we need to explain how flags are handled now. How does the user know
which flags are passed to gtest-parallel and the test binary itself? Please
provide some similar example as the one we had.

I interpret the code below as everything that comes before -- is sent to
gtest-parallel and the stuff after goes to the test binary. Let's make that
clear in the documentation as well.

[commit-bot: I haz the power, 2017-05-04 09:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 09:36:33]

Dry run: This issue passed the CQ dry run.

[ehmaldonado_webrtc, 2017-05-04 11:18:31]

Description was changed from

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

BUG=webrtc:7568
==========

to

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Also, move the --timeout=900 flag from the recipe to the mb.py script. That way
it is passed as an arg to gtest-parallel and not to the test executable.

BUG=webrtc:7568
==========

[kjellander_webrtc, 2017-05-04 11:50:10]

Excellent, thanks!
lgtm with nits addressed

https://codereview.webrtc.org/2862803002/diff/20001/tools-webrtc/gtest-parall...
File tools-webrtc/gtest-parallel-wrapper.py (right):

https://codereview.webrtc.org/2862803002/diff/20001/tools-webrtc/gtest-parall...
tools-webrtc/gtest-parallel-wrapper.py:21: All flags before '--' will be passed
as arguments to gtest_parallel, and
nit: gtest_parallel -> gtest-parallel

https://codereview.webrtc.org/2862803002/diff/20001/tools-webrtc/gtest-parall...
tools-webrtc/gtest-parallel-wrapper.py:34:
--isolated-script-test-chartson-output=some_other_dir \
chartson -> chartjson

https://codereview.webrtc.org/2862803002/diff/20001/tools-webrtc/mb/mb.py
File tools-webrtc/mb/mb.py (right):

https://codereview.webrtc.org/2862803002/diff/20001/tools-webrtc/mb/mb.py#new...
tools-webrtc/mb/mb.py:1101: '--timeout=900',
For future readers, let's add add a line with a comment before the timeout, to
explain why we have it.

[ehmaldonado_webrtc, 2017-05-04 12:17:19]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 12:17:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ehmaldonado_webrtc, 2017-05-04 12:47:11]

Description was changed from

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Also, move the --timeout=900 flag from the recipe to the mb.py script. That way
it is passed as an arg to gtest-parallel and not to the test executable.

BUG=webrtc:7568
==========

to

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Also, move the --timeout=900 flag from the recipe to the mb.py script. That way
it is passed as an arg to gtest-parallel and not to the test executable.

BUG=webrtc:7568
NOTRY=True
==========

[commit-bot: I haz the power, 2017-05-04 12:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 12:48:39]

Dry run: This issue passed the CQ dry run.

[ehmaldonado_webrtc, 2017-05-04 13:15:50]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-05-04 13:15:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2862803002/#ps40001 (title:
"Updated comments.")

[commit-bot: I haz the power, 2017-05-04 13:15:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-04 13:18:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493903750517070,
"parent_rev": "02739d9149c3b131703cc3df31c349afb9b097a5", "commit_rev":
"76e60e928f8f96c9d8686b0637952125a5f2649c"}

[commit-bot: I haz the power, 2017-05-04 13:18:31]

Description was changed from

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Also, move the --timeout=900 flag from the recipe to the mb.py script. That way
it is passed as an arg to gtest-parallel and not to the test executable.

BUG=webrtc:7568
NOTRY=True
==========

to

==========
Don't duplicate gtest-parallel flags in gtest-parallel-wrappers.

Also, move the --timeout=900 flag from the recipe to the mb.py script. That way
it is passed as an arg to gtest-parallel and not to the test executable.

BUG=webrtc:7568
NOTRY=True

Review-Url: https://codereview.webrtc.org/2862803002
Cr-Commit-Position: refs/heads/master@{#18015}
Committed:
https://chromium.googlesource.com/external/webrtc/+/76e60e928f8f96c9d8686b063...
==========

[commit-bot: I haz the power, 2017-05-04 13:18:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/76e60e928f8f96c9d8686b063...