Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools-webrtc/mb/mb.py

Issue 2862803002: Don't duplicate gtest-parallel flags in gtest-parallel-wrappers. (Closed)
Patch Set: Updated comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools-webrtc/gtest-parallel-wrapper.py ('k') | tools-webrtc/mb/mb_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license 4 # Use of this source code is governed by a BSD-style license
5 # that can be found in the LICENSE file in the root of the source 5 # that can be found in the LICENSE file in the root of the source
6 # tree. An additional intellectual property rights grant can be found 6 # tree. An additional intellectual property rights grant can be found
7 # in the file PATENTS. All contributing project authors may 7 # in the file PATENTS. All contributing project authors may
8 # be found in the AUTHORS file in the root of the source tree. 8 # be found in the AUTHORS file in the root of the source tree.
9 9
10 """MB - the Meta-Build wrapper around GYP and GN 10 """MB - the Meta-Build wrapper around GYP and GN
(...skipping 1078 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 1089
1090 if not memcheck: 1090 if not memcheck:
1091 extra_files += [ 1091 extra_files += [
1092 '../../third_party/gtest-parallel/gtest-parallel', 1092 '../../third_party/gtest-parallel/gtest-parallel',
1093 '../../tools-webrtc/gtest-parallel-wrapper.py', 1093 '../../tools-webrtc/gtest-parallel-wrapper.py',
1094 ] 1094 ]
1095 sep = '\\' if self.platform == 'win32' else '/' 1095 sep = '\\' if self.platform == 'win32' else '/'
1096 output_dir = '${ISOLATED_OUTDIR}' + sep + 'test_logs' 1096 output_dir = '${ISOLATED_OUTDIR}' + sep + 'test_logs'
1097 gtest_parallel_wrapper = [ 1097 gtest_parallel_wrapper = [
1098 '../../tools-webrtc/gtest-parallel-wrapper.py', 1098 '../../tools-webrtc/gtest-parallel-wrapper.py',
1099 '--output_dir=%s' % output_dir,
1099 '--gtest_color=no', 1100 '--gtest_color=no',
1100 '--output_dir=%s' % output_dir, 1101 # We tell gtest-parallel to interrupt the test after 900 seconds,
1102 # so it can exit cleanly and report results, instead of being
1103 # interrupted by swarming and not reporting anything.
1104 '--timeout=900',
1101 ] 1105 ]
1102 1106
1103 asan = 'is_asan=true' in vals['gn_args'] 1107 asan = 'is_asan=true' in vals['gn_args']
1104 msan = 'is_msan=true' in vals['gn_args'] 1108 msan = 'is_msan=true' in vals['gn_args']
1105 tsan = 'is_tsan=true' in vals['gn_args'] 1109 tsan = 'is_tsan=true' in vals['gn_args']
1106 1110
1107 executable_prefix = '.\\' if self.platform == 'win32' else './' 1111 executable_prefix = '.\\' if self.platform == 'win32' else './'
1108 executable_suffix = '.exe' if self.platform == 'win32' else '' 1112 executable_suffix = '.exe' if self.platform == 'win32' else ''
1109 executable = executable_prefix + target + executable_suffix 1113 executable = executable_prefix + target + executable_suffix
1110 1114
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 # Then check to see if the arg contains any metacharacters other than 1536 # Then check to see if the arg contains any metacharacters other than
1533 # double quotes; if it does, quote everything (including the double 1537 # double quotes; if it does, quote everything (including the double
1534 # quotes) for safety. 1538 # quotes) for safety.
1535 if any(a in UNSAFE_FOR_CMD for a in arg): 1539 if any(a in UNSAFE_FOR_CMD for a in arg):
1536 arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg) 1540 arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg)
1537 return arg 1541 return arg
1538 1542
1539 1543
1540 if __name__ == '__main__': 1544 if __name__ == '__main__':
1541 sys.exit(main(sys.argv[1:])) 1545 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « tools-webrtc/gtest-parallel-wrapper.py ('k') | tools-webrtc/mb/mb_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698