Make fps NSInteger in startCaptureWithDevice.

Make fps NSInteger in startCaptureWithDevice.

This is better in line with Obj-C design guidelines.

BUG=None

Review-Url: https://codereview.webrtc.org/2862493003
Cr-Commit-Position: refs/heads/master@{#18023}
Committed: https://chromium.googlesource.com/external/webrtc/+/ea12f4c5e8e5bf87f73d065405db3703a9f839d8

[sakal, 2017-05-03 14:48:28]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 14:48:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2017-05-03 14:49:23]

Description was changed from

==========
Make fps NSInteger in startCaptureWithDevice.

This is better in line with Obj-C design guidelines.

BUG=None
==========

to

==========
Make fps NSInteger in startCaptureWithDevice.

This is better in line with Obj-C design guidelines.

BUG=None
==========

[sakal, 2017-05-03 14:49:23]

sakal@webrtc.org changed reviewers:
+ denicija@webrtc.org, magjed@webrtc.org

[sakal, 2017-05-03 14:49:31]

PTAL

[commit-bot: I haz the power, 2017-05-03 15:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:11:27]

Dry run: Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/20175)

[daniela-webrtc, 2017-05-04 07:17:10]

lgtm

[daniela-webrtc, 2017-05-04 07:17:11]

lgtm

[magjed_webrtc, 2017-05-04 09:48:54]

https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m (right):

https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m:123:
RTCLogInfo("startCaptureWithDevice %@ @ %d fps", format, (int)fps);
I don't think we are allowed to do C-style casts. Can't you print the NSInteger
directly using some other format specifier?

[sakal, 2017-05-04 14:34:03]

https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m (right):

https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m:123:
RTCLogInfo("startCaptureWithDevice %@ @ %d fps", format, (int)fps);
On 2017/05/04 09:48:54, magjed_webrtc wrote:
> I don't think we are allowed to do C-style casts. Can't you print the
NSInteger
> directly using some other format specifier?

Done.

[magjed_webrtc, 2017-05-04 15:28:01]

lgtm

[sakal, 2017-05-05 07:21:12]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2017-05-05 07:21:12]

The patchset sent to the CQ was uploaded after l-g-t-m from denicija@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2862493003/#ps20001 (title:
"Print NSInteger directly.")

[commit-bot: I haz the power, 2017-05-05 07:21:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-05 07:45:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493968872350320,
"parent_rev": "5825288a983c0c42231133accb1d8d6562f2a08e", "commit_rev":
"ea12f4c5e8e5bf87f73d065405db3703a9f839d8"}

[commit-bot: I haz the power, 2017-05-05 07:45:34]

Description was changed from

==========
Make fps NSInteger in startCaptureWithDevice.

This is better in line with Obj-C design guidelines.

BUG=None
==========

to

==========
Make fps NSInteger in startCaptureWithDevice.

This is better in line with Obj-C design guidelines.

BUG=None

Review-Url: https://codereview.webrtc.org/2862493003
Cr-Commit-Position: refs/heads/master@{#18023}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ea12f4c5e8e5bf87f73d06540...
==========

[commit-bot: I haz the power, 2017-05-05 07:45:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ea12f4c5e8e5bf87f73d06540...