Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2862493003: Make fps NSInteger in startCaptureWithDevice. (Closed)

Created:
3 years, 7 months ago by sakal
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make fps NSInteger in startCaptureWithDevice. This is better in line with Obj-C design guidelines. BUG=None Review-Url: https://codereview.webrtc.org/2862493003 Cr-Commit-Position: refs/heads/master@{#18023} Committed: https://chromium.googlesource.com/external/webrtc/+/ea12f4c5e8e5bf87f73d065405db3703a9f839d8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Print NSInteger directly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ARDCaptureController.m View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
sakal
PTAL
3 years, 7 months ago (2017-05-03 14:49:31 UTC) #5
daniela-webrtc
lgtm
3 years, 7 months ago (2017-05-04 07:17:10 UTC) #8
daniela-webrtc
lgtm
3 years, 7 months ago (2017-05-04 07:17:11 UTC) #9
magjed_webrtc
https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m File webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m (right): https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m#newcode123 webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m:123: RTCLogInfo("startCaptureWithDevice %@ @ %d fps", format, (int)fps); I don't ...
3 years, 7 months ago (2017-05-04 09:48:54 UTC) #10
sakal
https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m File webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m (right): https://codereview.webrtc.org/2862493003/diff/1/webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m#newcode123 webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m:123: RTCLogInfo("startCaptureWithDevice %@ @ %d fps", format, (int)fps); On 2017/05/04 ...
3 years, 7 months ago (2017-05-04 14:34:03 UTC) #11
magjed_webrtc
lgtm
3 years, 7 months ago (2017-05-04 15:28:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2862493003/20001
3 years, 7 months ago (2017-05-05 07:21:20 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 07:45:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ea12f4c5e8e5bf87f73d06540...

Powered by Google App Engine
This is Rietveld 408576698