Make fps NSInteger in startCaptureWithDevice.

webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 97 matching lines @@
     if (IsMediaSubTypeSupported(mediaSubType)) {
       [eligibleDeviceFormats addObject:format];
     }
   }
 
   return eligibleDeviceFormats;
 }
 
 - (void)startCaptureWithDevice:(AVCaptureDevice *)device
                         format:(AVCaptureDeviceFormat *)format
-                           fps:(int)fps {
+                           fps:(NSInteger)fps {
   _willBeRunning = true;
   [RTCDispatcher
       dispatchAsyncOnType:RTCDispatcherTypeCaptureSession
                     block:^{
-                      RTCLogInfo("startCaptureWithDevice %@ @ %d fps", format, fps);
+                      RTCLogInfo("startCaptureWithDevice %@ @ %d fps", format, (int)fps);

[magjed_webrtc, 2017/05/04 09:48:54]

I don't think we are allowed to do C-style casts. Can't you print the NSInteger
directly using some other format specifier?

[sakal, 2017/05/04 14:34:03]

Done.

 
 #if TARGET_OS_IPHONE
                       [[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications];
 #endif
 
                       _currentDevice = device;
 
                       NSError *error = nil;
                       if ([_currentDevice lockForConfiguration:&error]) {
                         [self updateDeviceCaptureFormat:format fps:fps];
@@ skipping 219 matching lines @@
     // TODO(denicija): Remove this color conversion and use the original capture format directly.
     kCVPixelBufferPixelFormatTypeKey : @(kCVPixelFormatType_420YpCbCr8BiPlanarFullRange)
   };
   videoDataOutput.alwaysDiscardsLateVideoFrames = NO;
   [videoDataOutput setSampleBufferDelegate:self queue:self.frameQueue];
   _videoDataOutput = videoDataOutput;
 }
 
 #pragma mark - Private, called inside capture queue
 
-- (void)updateDeviceCaptureFormat:(AVCaptureDeviceFormat *)format fps:(int)fps {
+- (void)updateDeviceCaptureFormat:(AVCaptureDeviceFormat *)format fps:(NSInteger)fps {
   NSAssert([RTCDispatcher isOnQueueForType:RTCDispatcherTypeCaptureSession],
            @"updateDeviceCaptureFormat must be called on the capture queue.");
   @try {
     _currentDevice.activeFormat = format;
     _currentDevice.activeVideoMinFrameDuration = CMTimeMake(1, fps);
   } @catch (NSException *exception) {
     RTCLogError(@"Failed to set active format!\n User info:%@", exception.userInfo);
     return;
   }
 }
@@ skipping 41 matching lines @@
     case UIDeviceOrientationFaceUp:
     case UIDeviceOrientationFaceDown:
     case UIDeviceOrientationUnknown:
       // Ignore.
       break;
   }
 #endif
 }
 
 @end