Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

NOTRY=true
BUG=none

Review-Url: https://codereview.webrtc.org/2862343002
Cr-Commit-Position: refs/heads/master@{#18049}
Committed: https://chromium.googlesource.com/external/webrtc/+/e61103dc6cc279cff81f9955fb7cee3ea3e6599f

[kwiberg-webrtc, 2017-05-05 19:28:48]

kwiberg@webrtc.org changed reviewers:
+ kjellander@webrtc.org, solenberg@webrtc.org

[the sun, 2017-05-05 19:36:43]

The change sounds reasonable to me, but for pragmatic reasons I think eng prod
should be represented in OWNERs as well. WDYT Henrik?

[kwiberg-webrtc, 2017-05-05 19:52:43]

On 2017/05/05 19:36:43, the sun wrote:
> The change sounds reasonable to me, but for pragmatic reasons I think eng prod
> should be represented in OWNERs as well. WDYT Henrik?

Would those same pragmatic reasons argue for representing eng prod in the root
OWNERS file too? In which case adding them to webrtc/api/OWNERS would be
redundant. But on the other hand, TBR might be a better tool for cases where
expedited landing of CLs is needed—I don't know.

kjellander@, if you think eng prod should be represented in either (or both) of
those OWNERS files, could you post a CL?

[kjellander_webrtc, 2017-05-08 06:57:35]

This makes sense. I relaxed it when I did the blanket changes from kjellander@
--> * in the whole tree, but it's a little too relaxed.

I think it's good to tighten up the access to:
/
/webrtc
/webrtc/api

How about transitioning those back from * --> kjellander@ for .gn+.gni?
I don't think I want to be an generic owner, since I don't have the coding
insight or C++ expertise, so I'd just have to pass many reviews onto other
owners.

https://codereview.webrtc.org/2862343002/diff/1/webrtc/api/OWNERS
File webrtc/api/OWNERS (left):

https://codereview.webrtc.org/2862343002/diff/1/webrtc/api/OWNERS#oldcode12
webrtc/api/OWNERS:12: per-file *.gn=*
How about having me replace the wildcard here instead?

[kwiberg-webrtc, 2017-05-08 10:10:19]

Description was changed from

==========
Don't add or rename files in webrtc/api/ without a proper review

NOTRY=true
BUG=none
==========

to

==========
Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

NOTRY=true
BUG=none
==========

[kwiberg-webrtc, 2017-05-08 10:11:26]

Description was changed from

==========
Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

NOTRY=true
BUG=none
==========

to

==========
Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

NOTRY=true
BUG=none
==========

[kwiberg-webrtc, 2017-05-08 10:13:43]

New patch set uploaded; it replaces * with kjellander@ in webrtc/ and
webrtc/api/. (The root didn't have a * to replace, so I didn't touch
it---kjellander already is OWNER of ".gn" in that directory.)

https://codereview.webrtc.org/2862343002/diff/1/webrtc/api/OWNERS
File webrtc/api/OWNERS (left):

https://codereview.webrtc.org/2862343002/diff/1/webrtc/api/OWNERS#oldcode12
webrtc/api/OWNERS:12: per-file *.gn=*
On 2017/05/08 06:57:35, kjellander_webrtc wrote:
> How about having me replace the wildcard here instead?

Done.

[the sun, 2017-05-08 10:37:11]

lgtm

https://codereview.webrtc.org/2862343002/diff/20001/webrtc/api/OWNERS
File webrtc/api/OWNERS (right):

https://codereview.webrtc.org/2862343002/diff/20001/webrtc/api/OWNERS#newcode10
webrtc/api/OWNERS:10: # webrtc/api/ has NO blanket exception letting everyone
change *.gn
Not sure this comment really is required here. Also, it is better to write
comments that don't implicitly reference other comments.

[kjellander_webrtc, 2017-05-08 12:17:10]

lgtm

[kwiberg-webrtc, 2017-05-08 12:58:24]

https://codereview.webrtc.org/2862343002/diff/20001/webrtc/api/OWNERS
File webrtc/api/OWNERS (right):

https://codereview.webrtc.org/2862343002/diff/20001/webrtc/api/OWNERS#newcode10
webrtc/api/OWNERS:10: # webrtc/api/ has NO blanket exception letting everyone
change *.gn
On 2017/05/08 10:37:11, the sun wrote:
> Not sure this comment really is required here. Also, it is better to write
> comments that don't implicitly reference other comments.

OK, I'll remove this comment (and the corresponding one in the other file).

[kwiberg-webrtc, 2017-05-08 12:59:36]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2017-05-08 12:59:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2862343002/#ps40001 (title:
"kill comments")

[commit-bot: I haz the power, 2017-05-08 12:59:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-08 13:01:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494248376062310,
"parent_rev": "3149e09156dec38d44dcdbdcf2566d054bfac4f5", "commit_rev":
"e61103dc6cc279cff81f9955fb7cee3ea3e6599f"}

[commit-bot: I haz the power, 2017-05-08 13:01:59]

Description was changed from

==========
Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

NOTRY=true
BUG=none
==========

to

==========
Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

NOTRY=true
BUG=none

Review-Url: https://codereview.webrtc.org/2862343002
Cr-Commit-Position: refs/heads/master@{#18049}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e61103dc6cc279cff81f9955f...
==========

[commit-bot: I haz the power, 2017-05-08 13:02:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/e61103dc6cc279cff81f9955f...