webrtc/api/OWNERS - Issue 2862343002: Don't add or rename files in webrtc/ and webrtc/api/ without a proper review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/api/OWNERS

Issue 2862343002: Don't add or rename files in webrtc/ and webrtc/api/ without a proper review (Closed)

Patch Set: apply changes suggested by kjellander@ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 pthatcher@webrtc.org	1 pthatcher@webrtc.org

2 glaznev@webrtc.org	2 glaznev@webrtc.org

3 juberti@webrtc.org	3 juberti@webrtc.org

4 perkj@webrtc.org	4 perkj@webrtc.org

5 solenberg@webrtc.org	5 solenberg@webrtc.org

6 tkchin@webrtc.org	6 tkchin@webrtc.org

7 tommi@webrtc.org	7 tommi@webrtc.org

8 deadbeef@webrtc.org	8 deadbeef@webrtc.org

9	9

10 # These are for the common case of adding or renaming files. If you're doing	10 # webrtc/api/ has NO blanket exception letting everyone change *.gn
	the sun 2017/05/08 10:37:11 Not sure this comment really is required here. Als Not sure this comment really is required here. Also, it is better to write comments that don't implicitly reference other comments. kwiberg-webrtc 2017/05/08 12:58:24 OK, I'll remove this comment (and the correspondin Show quoted text On 2017/05/08 10:37:11, the sun wrote: > Not sure this comment really is required here. Also, it is better to write > comments that don't implicitly reference other comments. OK, I'll remove this comment (and the corresponding one in the other file).
11 # structural changes, please get a review from a reviewer in this file.	11 # and *.gni files in order to add or rename files, since such changes

12 per-file .gn=	12 # affect our public API.

13 per-file .gni=	13 per-file *.gn=kjellander@webrtc.org

	14 per-file *.gni=kjellander@webrtc.org

OLD	NEW

« no previous file with comments | « webrtc/OWNERS ('k') | no next file » | no next file with comments »