Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2861443004: Reland of Don't reinit encoder when rotation changes. (Closed)

Created:
3 years, 7 months ago by brandtr
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Don't reinit encoder when rotation changes. (patchset #1 id:1 of https://codereview.webrtc.org/2861633003/ ) Reason for revert: Fix compile. Original issue's description: > Revert of Don't reinit encoder when rotation changes. (patchset #3 id:40001 of https://codereview.webrtc.org/2853463004/ ) > > Reason for revert: > Breaks compile on buildbots. > > Original issue's description: > > Don't reinit encoder when rotation changes. > > > > TESTED=By rotating phone in AppRTCMobile. > > BUG=webrtc:7535 > > > > Review-Url: https://codereview.webrtc.org/2853463004 > > Cr-Commit-Position: refs/heads/master@{#17985} > > Committed: https://chromium.googlesource.com/external/webrtc/+/70e39e159eb350cb1acbf81dbe0d84d51c77b664 > > TBR=magjed@webrtc.org,asapersson@webrtc.org,perkj@webrtc.org,sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7535 > > Review-Url: https://codereview.webrtc.org/2861633003 > Cr-Commit-Position: refs/heads/master@{#17987} > Committed: https://chromium.googlesource.com/external/webrtc/+/823e900d2c917e4f110b28a705ca8e2c7b0b0c09 TBR=magjed@webrtc.org,asapersson@webrtc.org,perkj@webrtc.org,sprang@webrtc.org NOPRESUBMIT=true BUG=webrtc:7535 Review-Url: https://codereview.webrtc.org/2861443004 Cr-Commit-Position: refs/heads/master@{#17988} Committed: https://chromium.googlesource.com/external/webrtc/+/a3241666824af686497dc7c5e48d61278dbbf5ea

Patch Set 1 : Original CL #

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
brandtr
Created Reland of Don't reinit encoder when rotation changes.
3 years, 7 months ago (2017-05-03 11:07:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861443004/110001
3 years, 7 months ago (2017-05-03 11:55:39 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 11:55:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:110001) as
https://chromium.googlesource.com/external/webrtc/+/a3241666824af686497dc7c5e...

Powered by Google App Engine
This is Rietveld 408576698