Chromium Code Reviews

Issue 2861633003: Revert of Don't reinit encoder when rotation changes. (Closed)

Created:
3 years, 7 months ago by brandtr
Modified:
3 years, 7 months ago
Reviewers:
magjed_webrtc, åsapersson, perkj_webrtc, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Don't reinit encoder when rotation changes. (patchset #3 id:40001 of https://codereview.webrtc.org/2853463004/ ) Reason for revert: Breaks compile on buildbots. Original issue's description: > Don't reinit encoder when rotation changes. > > TESTED=By rotating phone in AppRTCMobile. > BUG=webrtc:7535 > > Review-Url: https://codereview.webrtc.org/2853463004 > Cr-Commit-Position: refs/heads/master@{#17985} > Committed: https://chromium.googlesource.com/external/webrtc/+/70e39e159eb350cb1acbf81dbe0d84d51c77b664 TBR=magjed@webrtc.org,asapersson@webrtc.org,perkj@webrtc.org,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7535 Review-Url: https://codereview.webrtc.org/2861633003 Cr-Commit-Position: refs/heads/master@{#17987} Committed: https://chromium.googlesource.com/external/webrtc/+/823e900d2c917e4f110b28a705ca8e2c7b0b0c09

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+11 lines, -45 lines)
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments
M webrtc/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments
M webrtc/video/vie_encoder.h View 1 chunk +3 lines, -0 lines 0 comments
M webrtc/video/vie_encoder.cc View 2 chunks +8 lines, -5 lines 0 comments

Messages

Total messages: 7 (3 generated)
brandtr
Created Revert of Don't reinit encoder when rotation changes.
3 years, 7 months ago (2017-05-03 10:53:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861633003/1
3 years, 7 months ago (2017-05-03 10:53:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/823e900d2c917e4f110b28a705ca8e2c7b0b0c09
3 years, 7 months ago (2017-05-03 10:53:13 UTC) #6
brandtr
3 years, 7 months ago (2017-05-03 11:07:00 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2861443004/ by brandtr@webrtc.org.

The reason for reverting is: Fix compile..

Powered by Google App Engine