Remove layer_sync from TL frame config.

Remove layer_sync from TL frame config.

This is instead derived from pattern_idx inside the frame config.

This also removes active_layer_ use from
ScreenshareLayers::PopulateCodecSpecific and instead ties the layer to
TemporalLayers::FrameConfig.

BUG=chromium:702017, webrtc:7349
R=sprang@webrtc.org

Review-Url: https://codereview.webrtc.org/2860063002
Cr-Commit-Position: refs/heads/master@{#18017}
Committed: https://chromium.googlesource.com/external/webrtc/+/51f083ccb2bb41acab552fefb5118598f998c23d

[pbos-webrtc, 2017-05-04 12:06:02]

Description was changed from

==========
Remove layer_sync from TL frame config.

Instead is instead derived from pattern_idx inside the frame config.

This also removes active_layer_ use from
ScreenshareLayers::PopulateCodecSpecific and instead ties the layer to
TemporalLayers::FrameConfig.

BUG=chromium:702017, webrtc:7349
R=sprang@webrtc.org
==========

to

==========
Remove layer_sync from TL frame config.

This is instead derived from pattern_idx inside the frame config.

This also removes active_layer_ use from
ScreenshareLayers::PopulateCodecSpecific and instead ties the layer to
TemporalLayers::FrameConfig.

BUG=chromium:702017, webrtc:7349
R=sprang@webrtc.org
==========

[pbos-webrtc, 2017-05-04 12:06:07]

PTAL

[sprang_webrtc, 2017-05-04 12:32:56]

lgtm with nits

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc (right):

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:113: enum
TemporalLayerState layer_state = kDrop;
why enum kw?

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:284: case kTl1:
Do we use the rtc_fallthrough() macro or whatever it's called?

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:44: FreezeEntropy);
This one was confused me. Makes the usage more readable though I guess, so I'll
let's you decide if this sugar is really worth it :)

[pbos-webrtc, 2017-05-04 13:11:59]

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc (right):

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:113: enum
TemporalLayerState layer_state = kDrop;
On 2017/05/04 12:32:55, sprang_webrtc wrote:
> why enum kw?

Done.

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:284: case kTl1:
On 2017/05/04 12:32:55, sprang_webrtc wrote:
> Do we use the rtc_fallthrough() macro or whatever it's called?

I believe only when case X doesn't directly follow case Y, e.g.:

case foo:
  do_thing();
case bar:
  do_another_thing_for_both();

would require the fallthrough macro.

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2860063002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:44: FreezeEntropy);
On 2017/05/04 12:32:55, sprang_webrtc wrote:
> This one was confused me. Makes the usage more readable though I guess, so
I'll
> let's you decide if this sugar is really worth it :)

I'd like to not have kNoFreezeEntropy, so keeping for now. :)

[pbos-webrtc, 2017-05-04 13:13:05]

remove enum

[pbos-webrtc, 2017-05-04 13:14:08]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2017-05-04 13:14:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2860063002/#ps20001 (title:
"remove enum")

[commit-bot: I haz the power, 2017-05-04 13:14:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-04 13:39:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493903648800360,
"parent_rev": "99ef6b78547795dbeacb88fab350e9a67703c67d", "commit_rev":
"51f083ccb2bb41acab552fefb5118598f998c23d"}

[commit-bot: I haz the power, 2017-05-04 13:39:08]

Description was changed from

==========
Remove layer_sync from TL frame config.

This is instead derived from pattern_idx inside the frame config.

This also removes active_layer_ use from
ScreenshareLayers::PopulateCodecSpecific and instead ties the layer to
TemporalLayers::FrameConfig.

BUG=chromium:702017, webrtc:7349
R=sprang@webrtc.org
==========

to

==========
Remove layer_sync from TL frame config.

This is instead derived from pattern_idx inside the frame config.

This also removes active_layer_ use from
ScreenshareLayers::PopulateCodecSpecific and instead ties the layer to
TemporalLayers::FrameConfig.

BUG=chromium:702017, webrtc:7349
R=sprang@webrtc.org

Review-Url: https://codereview.webrtc.org/2860063002
Cr-Commit-Position: refs/heads/master@{#18017}
Committed:
https://chromium.googlesource.com/external/webrtc/+/51f083ccb2bb41acab552fefb...
==========

[commit-bot: I haz the power, 2017-05-04 13:39:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/51f083ccb2bb41acab552fefb...