Remove layer_sync from TL frame config.

webrtc/modules/video_coding/codecs/vp8/temporal_layers.h

 /* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
 *
 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree. An additional intellectual property rights grant can be found
 *  in the file PATENTS.  All contributing project authors may
 *  be found in the AUTHORS file in the root of the source tree.
 */
 /*
 * This file defines the interface for doing temporal layers with VP8.
 */
 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_TEMPORAL_LAYERS_H_
 #define WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_TEMPORAL_LAYERS_H_
 
 #include <vector>
 
 #include "webrtc/common_video/include/video_image.h"
 #include "webrtc/typedefs.h"
 
 struct vpx_codec_enc_cfg;
 typedef struct vpx_codec_enc_cfg vpx_codec_enc_cfg_t;
 
 namespace webrtc {
 
 struct CodecSpecificInfoVP8;
 
-// TODO(pbos): Remove along with layer_sync and freeze_entropy, they are
-// derivable from picture_idx and should be exposed with
-// TL::IsLayerSync(TL::FrameConfig).
-enum TemporalFlags { kLayerSync = 1, kFreezeEntropy = 2 };
-
 class TemporalLayers {
  public:
   enum BufferFlags {
     kNone = 0,
     kReference = 1,
     kUpdate = 2,
     kReferenceAndUpdate = kReference | kUpdate,
   };
+  enum FreezeEntropy { kFreezeEntropy };
 
   struct FrameConfig {
     FrameConfig();
 
     FrameConfig(BufferFlags last, BufferFlags golden, BufferFlags arf);
     FrameConfig(BufferFlags last,
                 BufferFlags golden,
                 BufferFlags arf,
-                int extra_flags);
+                FreezeEntropy);

[sprang_webrtc, 2017/05/04 12:32:55]

This one was confused me. Makes the usage more readable though I guess, so I'll
let's you decide if this sugar is really worth it :)

[pbos-webrtc, 2017/05/04 13:11:59]

I'd like to not have kNoFreezeEntropy, so keeping for now. :)

 
     bool drop_frame;
     BufferFlags last_buffer_flags;
     BufferFlags golden_buffer_flags;
     BufferFlags arf_buffer_flags;
 
     // TODO(pbos): Consider breaking these out of here and returning only a
     // pattern index that needs to be returned to fill CodecSpecificInfoVP8 or
     // EncodeFlags.
     bool layer_sync;
     bool freeze_entropy;
 
     int pattern_idx;
 
    private:
     FrameConfig(BufferFlags last,
                 BufferFlags golden,
                 BufferFlags arf,
-                bool layer_sync,
                 bool freeze_entropy);
   };
 
   // Factory for TemporalLayer strategy. Default behavior is a fixed pattern
   // of temporal layers. See default_temporal_layers.cc
   virtual ~TemporalLayers() {}
 
   // Returns the recommended VP8 encode flags needed. May refresh the decoder
   // and/or update the reference buffers.
   virtual FrameConfig UpdateLayerConfig(uint32_t timestamp) = 0;
@@ skipping 51 matching lines @@
  public:
   TemporalLayersListener() {}
   virtual ~TemporalLayersListener() {}
 
   virtual void OnTemporalLayersCreated(int simulcast_id,
                                        TemporalLayers* layers) = 0;
 };
 
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_TEMPORAL_LAYERS_H_