Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Issue 2860033002: Reland of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (Closed)

Created:
3 years, 7 months ago by magjed_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #1 id:1 of https://codereview.webrtc.org/2862663003/ ) Reason for revert: Keep header file for backwards compatibility Original issue's description: > Revert of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #2 id:60001 of https://codereview.webrtc.org/2851563003/ ) > > Reason for revert: > Breaks downstream targets. > > Original issue's description: > > Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ > > > > CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into > > the webrtc/sdk/objc/ folder. > > > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/2851563003 > > Cr-Commit-Position: refs/heads/master@{#17998} > > Committed: https://chromium.googlesource.com/external/webrtc/+/d41631aa274e926c4fba1600cbcfbc18020eb35a > > TBR=kthelgason@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2862663003 > Cr-Commit-Position: refs/heads/master@{#18004} > Committed: https://chromium.googlesource.com/external/webrtc/+/c34e730896032ae730b5917306bb4f79e62d03dd TBR=kthelgason@webrtc.org,ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2860033002 Cr-Commit-Position: refs/heads/master@{#18011} Committed: https://chromium.googlesource.com/external/webrtc/+/173658968e80cc25e98038feb05efd750bdb8e9d

Patch Set 1 #

Patch Set 2 : Fix include guards. #

Patch Set 3 : Rebase #

Patch Set 4 : Actually move CoreVideoFrameBuffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -162 lines) Patch
M webrtc/common_video/BUILD.gn View 1 3 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/common_video/corevideo_frame_buffer.cc View 3 1 chunk +0 lines, -148 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 3 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 3 3 chunks +16 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/DEPS View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 3 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/corevideo_frame_buffer.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc View 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/objcvideotracksource.mm View 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (20 generated)
magjed_webrtc
Created Reland of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/
3 years, 7 months ago (2017-05-04 07:52:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2860033002/240001
3 years, 7 months ago (2017-05-04 10:41:31 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 10:41:38 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:240001) as
https://chromium.googlesource.com/external/webrtc/+/173658968e80cc25e98038feb...

Powered by Google App Engine
This is Rietveld 408576698