Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into
the webrtc/sdk/objc/ folder.

BUG=None

Review-Url: https://codereview.webrtc.org/2851563003
Cr-Commit-Position: refs/heads/master@{#17998}
Committed: https://chromium.googlesource.com/external/webrtc/+/d41631aa274e926c4fba1600cbcfbc18020eb35a

[magjed_webrtc, 2017-05-01 13:38:43]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 13:38:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-01 13:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 13:41:02]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/25247)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/24283)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/25267)

[magjed_webrtc, 2017-05-01 14:11:44]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 14:13:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-01 14:18:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 14:18:16]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16604)

[magjed_webrtc, 2017-05-03 11:48:34]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2017-05-03 11:48:39]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2017-05-03 11:50:44]

Description was changed from

==========
Move CoreVideoFrameBuffer
==========

to

==========
Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into
the webrtc/sdk/objc/ folder.
==========

[magjed_webrtc, 2017-05-03 11:50:45]

magjed@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[magjed_webrtc, 2017-05-03 11:50:59]

Kári - please take a look.

[kthelgason, 2017-05-03 12:33:23]

one minor comment that you can feel free to ignore.
lgtm

https://codereview.webrtc.org/2851563003/diff/40001/webrtc/common_video/libyu...
File webrtc/common_video/libyuv/webrtc_libyuv.cc (right):

https://codereview.webrtc.org/2851563003/diff/40001/webrtc/common_video/libyu...
webrtc/common_video/libyuv/webrtc_libyuv.cc:371:
NV12ToI420Scaler::~NV12ToI420Scaler() {}
If these are going to have a default implementation I prefer using =default in
the header file. That way one doesn't have to check the implementation to see
that the c/dtor are compiler generated.

[magjed_webrtc, 2017-05-03 12:55:11]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-05-03 12:55:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2851563003/#ps60001 (title:
"Use = default")

[commit-bot: I haz the power, 2017-05-03 12:55:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-03 13:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 13:00:51]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16704)

[magjed_webrtc, 2017-05-03 14:04:54]

https://codereview.webrtc.org/2851563003/diff/40001/webrtc/common_video/libyu...
File webrtc/common_video/libyuv/webrtc_libyuv.cc (right):

https://codereview.webrtc.org/2851563003/diff/40001/webrtc/common_video/libyu...
webrtc/common_video/libyuv/webrtc_libyuv.cc:371:
NV12ToI420Scaler::~NV12ToI420Scaler() {}
On 2017/05/03 12:33:23, kthelgason wrote:
> If these are going to have a default implementation I prefer using =default in
> the header file. That way one doesn't have to check the implementation to see
> that the c/dtor are compiler generated.

Good point!
The reason I did this in this CL is because of the error:
[chromium-style] Complex constructor has an inlined body.
I switched to using =default, but I still need to put it in the .cc-file,
othewise I still get the error.

[magjed_webrtc, 2017-05-03 14:05:39]

Description was changed from

==========
Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into
the webrtc/sdk/objc/ folder.
==========

to

==========
Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into
the webrtc/sdk/objc/ folder.

BUG=None
==========

[magjed_webrtc, 2017-05-03 14:05:46]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-05-03 14:05:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-05-03 14:08:25]

On 2017/05/03 14:04:54, magjed_webrtc wrote:
>
https://codereview.webrtc.org/2851563003/diff/40001/webrtc/common_video/libyu...
> File webrtc/common_video/libyuv/webrtc_libyuv.cc (right):
> 
>
https://codereview.webrtc.org/2851563003/diff/40001/webrtc/common_video/libyu...
> webrtc/common_video/libyuv/webrtc_libyuv.cc:371:
> NV12ToI420Scaler::~NV12ToI420Scaler() {}
> On 2017/05/03 12:33:23, kthelgason wrote:
> > If these are going to have a default implementation I prefer using =default
in
> > the header file. That way one doesn't have to check the implementation to
see
> > that the c/dtor are compiler generated.
> 
> Good point!
> The reason I did this in this CL is because of the error:
> [chromium-style] Complex constructor has an inlined body.
> I switched to using =default, but I still need to put it in the .cc-file,
> othewise I still get the error.

Got it, thanks for the clarification.

[commit-bot: I haz the power, 2017-05-03 14:10:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493820346168770,
"parent_rev": "5d153c76c60fc3388d60ff3b84a9b4b5557c57ad", "commit_rev":
"d41631aa274e926c4fba1600cbcfbc18020eb35a"}

[commit-bot: I haz the power, 2017-05-03 14:10:15]

Description was changed from

==========
Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into
the webrtc/sdk/objc/ folder.

BUG=None
==========

to

==========
Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/

CoreVideoFrameBuffer is Mac/iPhone specific and should be moved into
the webrtc/sdk/objc/ folder.

BUG=None

Review-Url: https://codereview.webrtc.org/2851563003
Cr-Commit-Position: refs/heads/master@{#17998}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d41631aa274e926c4fba1600c...
==========

[commit-bot: I haz the power, 2017-05-03 14:10:16]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/d41631aa274e926c4fba1600c...

[lliuu1, 2017-05-03 17:55:05]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.webrtc.org/2859843003/ by lliuu@google.com.

The reason for reverting is: Revert since it breaks build of internal projects.

[ehmaldonado_webrtc, 2017-05-03 20:25:23]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.webrtc.org/2862663003/ by ehmaldonado@webrtc.org.

The reason for reverting is: Breaks downstream targets..

[lliuu, 2017-05-03 20:56:22]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.webrtc.org/2857103006/ by lliuu@webrtc.org.

The reason for reverting is: API changes broke internal projects.