Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2859223003: WebRtcVideoEncoderFactory cleanup (Closed)

Created:
3 years, 7 months ago by magjed_webrtc
Modified:
3 years, 7 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVideoEncoderFactory cleanup Remove some deprecated functions. BUG=webrtc:6402 Review-Url: https://codereview.webrtc.org/2859223003 Cr-Commit-Position: refs/heads/master@{#18116} Committed: https://chromium.googlesource.com/external/webrtc/+/c1a8974ebd89295f9ba6deb6200cad74d6181e30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -114 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtcvideoengine.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/internalencoderfactory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoencoderfactory.h View 2 chunks +2 lines, -40 lines 0 comments Download
M webrtc/media/engine/webrtcvideoencoderfactory.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/media/engine/webrtcvideoencoderfactory_unittest.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (20 generated)
magjed_webrtc
Sami - please take a look.
3 years, 7 months ago (2017-05-11 16:46:49 UTC) #16
sakal
lgtm
3 years, 7 months ago (2017-05-12 07:21:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2859223003/60001
3 years, 7 months ago (2017-05-12 07:21:48 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 07:24:44 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/c1a8974ebd89295f9ba6deb62...

Powered by Google App Engine
This is Rietveld 408576698