Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2859223003: WebRtcVideoEncoderFactory cleanup (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 factory_->DestroyVideoEncoder(encoder); 137 factory_->DestroyVideoEncoder(encoder);
138 return; 138 return;
139 } 139 }
140 140
141 // Otherwise, SimulcastEncoderAdapter can be deleted directly, and will call 141 // Otherwise, SimulcastEncoderAdapter can be deleted directly, and will call
142 // DestroyVideoEncoder on the factory for individual encoder instances. 142 // DestroyVideoEncoder on the factory for individual encoder instances.
143 delete encoder; 143 delete encoder;
144 } 144 }
145 145
146 private: 146 private:
147 // Disable overloaded virtual function warning. TODO(magjed): Remove once
148 // http://crbug/webrtc/6402 is fixed.
149 using cricket::WebRtcVideoEncoderFactory::CreateVideoEncoder;
150
151 cricket::WebRtcVideoEncoderFactory* factory_; 147 cricket::WebRtcVideoEncoderFactory* factory_;
152 // A list of encoders that were created without being wrapped in a 148 // A list of encoders that were created without being wrapped in a
153 // SimulcastEncoderAdapter. 149 // SimulcastEncoderAdapter.
154 std::vector<webrtc::VideoEncoder*> non_simulcast_encoders_; 150 std::vector<webrtc::VideoEncoder*> non_simulcast_encoders_;
155 }; 151 };
156 152
157 void AddDefaultFeedbackParams(VideoCodec* codec) { 153 void AddDefaultFeedbackParams(VideoCodec* codec) {
158 codec->AddFeedbackParam(FeedbackParam(kRtcpFbParamCcm, kRtcpFbCcmParamFir)); 154 codec->AddFeedbackParam(FeedbackParam(kRtcpFbParamCcm, kRtcpFbCcmParamFir));
159 codec->AddFeedbackParam(FeedbackParam(kRtcpFbParamNack, kParamValueEmpty)); 155 codec->AddFeedbackParam(FeedbackParam(kRtcpFbParamNack, kParamValueEmpty));
160 codec->AddFeedbackParam(FeedbackParam(kRtcpFbParamNack, kRtcpFbNackParamPli)); 156 codec->AddFeedbackParam(FeedbackParam(kRtcpFbParamNack, kRtcpFbNackParamPli));
(...skipping 2438 matching lines...) Expand 10 before | Expand all | Expand 10 after
2599 rtx_mapping[video_codecs[i].codec.id] != 2595 rtx_mapping[video_codecs[i].codec.id] !=
2600 ulpfec_config.red_payload_type) { 2596 ulpfec_config.red_payload_type) {
2601 video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id]; 2597 video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id];
2602 } 2598 }
2603 } 2599 }
2604 2600
2605 return video_codecs; 2601 return video_codecs;
2606 } 2602 }
2607 2603
2608 } // namespace cricket 2604 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoencoderfactory_unittest.cc ('k') | webrtc/sdk/android/src/jni/androidmediaencoder_jni.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698