Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2856963004: Revert of Roll gtest-parallel. (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll gtest-parallel. (patchset #1 id:1 of https://codereview.webrtc.org/2859133002/ ) Reason for revert: There might be a subtle bug where all tests are always reported as passing. Original issue's description: > Roll gtest-parallel c9bb1c9e8a..1e816d0426 > > * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+log/c9bb1c9e8a..1e816d0426 > > BUG=chromium:718339 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2859133002 > Cr-Commit-Position: refs/heads/master@{#18005} > Committed: https://chromium.googlesource.com/external/webrtc/+/5aa3f361299ab60d6ed6e8d7bd469fef8dba3b6b TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:718339 Review-Url: https://codereview.webrtc.org/2856963004 Cr-Commit-Position: refs/heads/master@{#18007} Committed: https://chromium.googlesource.com/external/webrtc/+/8417610a79b4097f0fe4b34b610aea65d20377ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
ehmaldonado_webrtc
Created Revert of Roll gtest-parallel.
3 years, 7 months ago (2017-05-04 08:14:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2856963004/1
3 years, 7 months ago (2017-05-04 08:15:00 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 08:15:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8417610a79b4097f0fe4b34b6...

Powered by Google App Engine
This is Rietveld 408576698