Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2859133002:
Roll gtest-parallel. (Closed)
|
Created:
3 years, 7 months ago by ehmaldonado_webrtc Modified:
3 years, 7 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll gtest-parallel c9bb1c9e8a..1e816d0426
* src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+log/c9bb1c9e8a..1e816d0426
BUG=chromium:718339
NOTRY=True
Review-Url: https://codereview.webrtc.org/2859133002
Cr-Commit-Position: refs/heads/master@{#18005}
Committed: https://chromium.googlesource.com/external/webrtc/+/5aa3f361299ab60d6ed6e8d7bd469fef8dba3b6b
Patch Set 1 #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Roll gtest-parallel. BUG= ========== to ========== Roll gtest-parallel c9bb1c9e8a..1e816d0426 * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+... BUG=chromium:718339 ==========
The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org
lgtm
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by ehmaldonado@webrtc.org
Description was changed from ========== Roll gtest-parallel c9bb1c9e8a..1e816d0426 * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+... BUG=chromium:718339 ========== to ========== Roll gtest-parallel c9bb1c9e8a..1e816d0426 * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+... BUG=chromium:718339 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493884802939100, "parent_rev":
"c34e730896032ae730b5917306bb4f79e62d03dd", "commit_rev":
"5aa3f361299ab60d6ed6e8d7bd469fef8dba3b6b"}
Message was sent while issue was closed.
Description was changed from ========== Roll gtest-parallel c9bb1c9e8a..1e816d0426 * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+... BUG=chromium:718339 NOTRY=True ========== to ========== Roll gtest-parallel c9bb1c9e8a..1e816d0426 * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+... BUG=chromium:718339 NOTRY=True Review-Url: https://codereview.webrtc.org/2859133002 Cr-Commit-Position: refs/heads/master@{#18005} Committed: https://chromium.googlesource.com/external/webrtc/+/5aa3f361299ab60d6ed6e8d7b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/5aa3f361299ab60d6ed6e8d7b...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2856963004/ by ehmaldonado@webrtc.org. The reason for reverting is: There might be a subtle bug where all tests are always reported as passing..
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
