Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2852793002: This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCap… (Closed)

Created:
3 years, 7 months ago by Hzj_jie
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/branch-heads/58
Project:
webrtc
Visibility:
Public.

Description

This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. BUG=712615 Review-Url: https://codereview.webrtc.org/2835553002 Cr-Commit-Position: refs/heads/master@{#17799} (cherry picked from commit d41af462fb11a4854e25a84bb0d27b8c3fdd5519) Review-Url: https://codereview.webrtc.org/2852793002 . Cr-Commit-Position: refs/branch-heads/58@{#18} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/6e1b4a90f041095449f0cbf5ae1cf7937345fc1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Hzj_jie
3 years, 7 months ago (2017-04-28 21:50:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e1b4a90f041095449f0cbf5ae1cf7937345fc1d.

Powered by Google App Engine
This is Rietveld 408576698