|
|
Created:
3 years, 8 months ago by Hzj_jie Modified:
3 years, 8 months ago Reviewers:
Sergey Ulanov CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Wez Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionThis change fixes a crash issue in WindowCapturerWin. The issue and fix are both
obvious, WindowCapturerWin should not return Result::SUCCESS with an empty
frame.
This issue was original introduced into the code base in change
https://codereview.webrtc.org/1988783003/.
I am also considering whether we should move the
previous_size_ = frame->size();
window_size_map_[window_] = previous_size_;
into the true branch. But since this change needs to be merged into M58 and M59,
I would prefer to keep it as small as possible.
BUG=712615
Review-Url: https://codereview.webrtc.org/2835553002
Cr-Commit-Position: refs/heads/master@{#17799}
Committed: https://chromium.googlesource.com/external/webrtc/+/d41af462fb11a4854e25a84bb0d27b8c3fdd5519
Patch Set 1 #
Messages
Total messages: 20 (15 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Crash in WindowCapturerWin BUG= ========== to ========== This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. R=SergeyU@chromium.org CC=Wez@chromium.org BUG=712615 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/13095) win_clang_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_rel/builds/12952) win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/24872)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #1 (id:1) has been deleted
zijiehe@chromium.org changed reviewers: + sergeyu@chromium.org
Description was changed from ========== This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. R=SergeyU@chromium.org CC=Wez@chromium.org BUG=712615 ========== to ========== This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. BUG=712615 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492725064472650, "parent_rev": "d07061c9f3ac5b0514ba02376d5a3ef471d2638b", "commit_rev": "d41af462fb11a4854e25a84bb0d27b8c3fdd5519"}
Message was sent while issue was closed.
Description was changed from ========== This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. BUG=712615 ========== to ========== This change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. BUG=712615 Review-Url: https://codereview.webrtc.org/2835553002 Cr-Commit-Position: refs/heads/master@{#17799} Committed: https://chromium.googlesource.com/external/webrtc/+/d41af462fb11a4854e25a84bb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/d41af462fb11a4854e25a84bb... |