Reland of Enable GN check for webrtc/base

Reland of Enable GN check for webrtc/base (patchset #1 id:1 of https://codereview.webrtc.org/2846483002/ )

Reason for revert:
Fixing the issue with //third_party/gflags and reland.

Failures: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23803

Original issue's description:
> Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of https://codereview.webrtc.org/2840453004/ )
> 
> Reason for revert:
> It causes a Chromium build error:
> 
> ERROR at //third_party/webrtc/test/BUILD.gn:113:5: Can't load input file.
>     "//third_party/gflags",
> 
> Original issue's description:
> > Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ )
> > 
> > Reason for revert:
> > Try to fix the webrtc/test/fuzzers issue and reland this CL because it 
> > contains lots of fixes for our BUILD.gn files.
> > 
> > Original issue's description:
> > > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ )
> > > 
> > > Reason for revert:
> > > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6).
> > > 
> > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer.
> > > 
> > > Original issue's description:
> > > > Enable GN check for webrtc/base
> > > > 
> > > > It's not possible to enable it for the rtc_base_approved
> > > > target but since a larger refactoring is ongoing for webrtc/base
> > > > this CL doesn't attempt to fix that.
> > > > 
> > > > Changes made:
> > > > * Move webrtc/system_wrappers/include/stringize_macros.h into 
> > > >   webrtc/base:rtc_base_approved_unittests (and corresponding
> > > >   unit test to rtc_base_approved_unittests).
> > > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target.
> > > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into
> > > >   webrtc/base.
> > > > * Remove unused use include of webrtc/base/fileutils.h in 
> > > >   webrtc/base/pathutils.cc
> > > > 
> > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > > NOTRY=True
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2717083002
> > > > Cr-Commit-Position: refs/heads/master@{#17766}
> > > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac
> > > 
> > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > NOTRY=True
> > > 
> > > Review-Url: https://codereview.webrtc.org/2838683002
> > > Cr-Commit-Position: refs/heads/master@{#17849}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae
> > 
> > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > 
> > Review-Url: https://codereview.webrtc.org/2840453004
> > Cr-Commit-Position: refs/heads/master@{#17876}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/7054085e59c3123613cd0014bedb0fe91a56e26f
> 
> TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828, webrtc:3806, webrtc:7480
> 
> Review-Url: https://codereview.webrtc.org/2846483002
> Cr-Commit-Position: refs/heads/master@{#17877}
> Committed: https://chromium.googlesource.com/external/webrtc/+/3d7b0e2fda64327a0182099160305e7098c1a277

TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828, webrtc:3806, webrtc:7480

[mbonadei, 2017-04-26 07:40:48]

Created Reland of Enable GN check for webrtc/base

[mbonadei, 2017-04-26 08:14:32]

Description was changed from

==========
Reland of Enable GN check for webrtc/base (patchset #1 id:1 of
https://codereview.webrtc.org/2846483002/ )

Reason for revert:
Fixing the issue with //third_party/gflags and reland.

Original issue's description:
> Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of
https://codereview.webrtc.org/2840453004/ )
> 
> Reason for revert:
> It causes a Chromium build error:
> 
> ERROR at //third_party/webrtc/test/BUILD.gn:113:5: Can't load input file.
>     "//third_party/gflags",
> 
> Original issue's description:
> > Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of
https://codereview.webrtc.org/2838683002/ )
> > 
> > Reason for revert:
> > Try to fix the webrtc/test/fuzzers issue and reland this CL because it 
> > contains lots of fixes for our BUILD.gn files.
> > 
> > Original issue's description:
> > > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of
https://codereview.webrtc.org/2717083002/ )
> > > 
> > > Reason for revert:
> > > Breaks Chromium because in Chromium we import WebRTC with
rtc_include_tests=false
(https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6).
> > > 
> > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to
neteq_rtc_fuzzer.
> > > 
> > > Original issue's description:
> > > > Enable GN check for webrtc/base
> > > > 
> > > > It's not possible to enable it for the rtc_base_approved
> > > > target but since a larger refactoring is ongoing for webrtc/base
> > > > this CL doesn't attempt to fix that.
> > > > 
> > > > Changes made:
> > > > * Move webrtc/system_wrappers/include/stringize_macros.h into 
> > > >   webrtc/base:rtc_base_approved_unittests (and corresponding
> > > >   unit test to rtc_base_approved_unittests).
> > > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target.
> > > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into
> > > >   webrtc/base.
> > > > * Remove unused use include of webrtc/base/fileutils.h in 
> > > >   webrtc/base/pathutils.cc
> > > > 
> > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > > NOTRY=True
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2717083002
> > > > Cr-Commit-Position: refs/heads/master@{#17766}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073...
> > > 
> > >
TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > NOTRY=True
> > > 
> > > Review-Url: https://codereview.webrtc.org/2838683002
> > > Cr-Commit-Position: refs/heads/master@{#17849}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2...
> > 
> > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > 
> > Review-Url: https://codereview.webrtc.org/2840453004
> > Cr-Commit-Position: refs/heads/master@{#17876}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/7054085e59c3123613cd0014b...
> 
> TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828, webrtc:3806, webrtc:7480
> 
> Review-Url: https://codereview.webrtc.org/2846483002
> Cr-Commit-Position: refs/heads/master@{#17877}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/3d7b0e2fda64327a018209916...

TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828, webrtc:3806, webrtc:7480
==========

to

==========
Reland of Enable GN check for webrtc/base (patchset #1 id:1 of
https://codereview.webrtc.org/2846483002/ )

Reason for revert:
Fixing the issue with //third_party/gflags and reland.

Failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...

Original issue's description:
> Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of
https://codereview.webrtc.org/2840453004/ )
> 
> Reason for revert:
> It causes a Chromium build error:
> 
> ERROR at //third_party/webrtc/test/BUILD.gn:113:5: Can't load input file.
>     "//third_party/gflags",
> 
> Original issue's description:
> > Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of
https://codereview.webrtc.org/2838683002/ )
> > 
> > Reason for revert:
> > Try to fix the webrtc/test/fuzzers issue and reland this CL because it 
> > contains lots of fixes for our BUILD.gn files.
> > 
> > Original issue's description:
> > > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of
https://codereview.webrtc.org/2717083002/ )
> > > 
> > > Reason for revert:
> > > Breaks Chromium because in Chromium we import WebRTC with
rtc_include_tests=false
(https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6).
> > > 
> > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to
neteq_rtc_fuzzer.
> > > 
> > > Original issue's description:
> > > > Enable GN check for webrtc/base
> > > > 
> > > > It's not possible to enable it for the rtc_base_approved
> > > > target but since a larger refactoring is ongoing for webrtc/base
> > > > this CL doesn't attempt to fix that.
> > > > 
> > > > Changes made:
> > > > * Move webrtc/system_wrappers/include/stringize_macros.h into 
> > > >   webrtc/base:rtc_base_approved_unittests (and corresponding
> > > >   unit test to rtc_base_approved_unittests).
> > > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target.
> > > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into
> > > >   webrtc/base.
> > > > * Remove unused use include of webrtc/base/fileutils.h in 
> > > >   webrtc/base/pathutils.cc
> > > > 
> > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > > NOTRY=True
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2717083002
> > > > Cr-Commit-Position: refs/heads/master@{#17766}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073...
> > > 
> > >
TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > > NOTRY=True
> > > 
> > > Review-Url: https://codereview.webrtc.org/2838683002
> > > Cr-Commit-Position: refs/heads/master@{#17849}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2...
> > 
> > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:6828, webrtc:3806, webrtc:7480
> > 
> > Review-Url: https://codereview.webrtc.org/2840453004
> > Cr-Commit-Position: refs/heads/master@{#17876}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/7054085e59c3123613cd0014b...
> 
> TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828, webrtc:3806, webrtc:7480
> 
> Review-Url: https://codereview.webrtc.org/2846483002
> Cr-Commit-Position: refs/heads/master@{#17877}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/3d7b0e2fda64327a018209916...

TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828, webrtc:3806, webrtc:7480
==========

[kjellander_webrtc, 2017-04-26 13:45:21]

https://codereview.webrtc.org/2846493002/diff/330001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2846493002/diff/330001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:109: ":field_trial",
I think we want to add ":isolated_output" here, since we want to be able to pass
that flag to all our tests.
The idea was for me to implement passing the flag to all tests after
https://bugs.chromium.org/p/webrtc/issues/detail?id=6732 was implemented, but I
never got to it (and we mostly wanted to have it to be able to archive
screenshots from failing tests related to that bug).

Just adding it to test_main would be sufficient to still make that possible, I
think.

https://codereview.webrtc.org/2846493002/diff/350001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2846493002/diff/350001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:112: "//testing/gtest",
Apparently Chrome gets test_main pulled in somehow according to the trybots. I
don't know where...

[mbonadei, 2017-04-26 13:50:05]

https://codereview.webrtc.org/2846493002/diff/330001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2846493002/diff/330001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:109: ":field_trial",
On 2017/04/26 13:45:20, kjellander_webrtc wrote:
> I think we want to add ":isolated_output" here, since we want to be able to
pass
> that flag to all our tests.
> The idea was for me to implement passing the flag to all tests after
> https://bugs.chromium.org/p/webrtc/issues/detail?id=6732 was implemented, but
I
> never got to it (and we mostly wanted to have it to be able to archive
> screenshots from failing tests related to that bug).
> 
> Just adding it to test_main would be sufficient to still make that possible, I
> think.

Ok, not I got it. Let me fix the issue on the gtest_prod and I will do it.

https://codereview.webrtc.org/2846493002/diff/350001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2846493002/diff/350001/webrtc/test/BUILD.gn#new...
webrtc/test/BUILD.gn:112: "//testing/gtest",
On 2017/04/26 13:45:20, kjellander_webrtc wrote:
> Apparently Chrome gets test_main pulled in somehow according to the trybots. I
> don't know where...

Yep, it is webrtc/base:gtest_prod that is a dependency of
webrtc/test:test_support even if it is not needed (it seems).

[mbonadei, 2017-04-27 10:00:32]

I close this CL for now.

In https://codereview.webrtc.org/2846803002/ we have been able to understand
what is going wrong and it is not related to this CL itself.

I will create another reland later.