Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2846483002: Revert of Enable GN check for webrtc/base (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, mbonadei
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable GN check for webrtc/base (patchset #9 id:350001 of https://codereview.webrtc.org/2840453004/ ) Reason for revert: It causes a Chromium build error: ERROR at //third_party/webrtc/test/BUILD.gn:113:5: Can't load input file. "//third_party/gflags", Original issue's description: > Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) > > Reason for revert: > Try to fix the webrtc/test/fuzzers issue and reland this CL because it > contains lots of fixes for our BUILD.gn files. > > Original issue's description: > > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > > > Reason for revert: > > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > > > Original issue's description: > > > Enable GN check for webrtc/base > > > > > > It's not possible to enable it for the rtc_base_approved > > > target but since a larger refactoring is ongoing for webrtc/base > > > this CL doesn't attempt to fix that. > > > > > > Changes made: > > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > > webrtc/base:rtc_base_approved_unittests (and corresponding > > > unit test to rtc_base_approved_unittests). > > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > > webrtc/base. > > > * Remove unused use include of webrtc/base/fileutils.h in > > > webrtc/base/pathutils.cc > > > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > > NOTRY=True > > > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > > Cr-Commit-Position: refs/heads/master@{#17766} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838683002 > > Cr-Commit-Position: refs/heads/master@{#17849} > > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > Review-Url: https://codereview.webrtc.org/2840453004 > Cr-Commit-Position: refs/heads/master@{#17876} > Committed: https://chromium.googlesource.com/external/webrtc/+/7054085e59c3123613cd0014bedb0fe91a56e26f TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2846483002 Cr-Commit-Position: refs/heads/master@{#17877} Committed: https://chromium.googlesource.com/external/webrtc/+/3d7b0e2fda64327a0182099160305e7098c1a277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -263 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 11 chunks +65 lines, -89 lines 0 comments Download
M webrtc/base/location.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/pathutils.cc View 1 chunk +1 line, -0 lines 0 comments Download
D webrtc/base/stringize_macros.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/base/stringize_macros_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 3 chunks +92 lines, -95 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A webrtc/system_wrappers/include/stringize_macros.h View 1 chunk +38 lines, -0 lines 0 comments Download
A webrtc/system_wrappers/source/stringize_macros_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Enable GN check for webrtc/base
3 years, 8 months ago (2017-04-26 07:38:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2846483002/1
3 years, 8 months ago (2017-04-26 07:38:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3d7b0e2fda64327a0182099160305e7098c1a277
3 years, 8 months ago (2017-04-26 07:38:55 UTC) #6
mbonadei
3 years, 8 months ago (2017-04-26 07:40:47 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2846493002/ by mbonadei@webrtc.org.

The reason for reverting is: Fixing the issue with //third_party/gflags and
reland..

Powered by Google App Engine
This is Rietveld 408576698