Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2845603002: Normalize codec names to those used by AcmCodecDatabase. (Closed)

Created:
3 years, 8 months ago by ossu
Modified:
3 years, 7 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Normalize codec names to those used by AcmCodecDatabase. With the upcoming changes to WebRtcVoiceEngine due to injectable audio encoders, codec names will no longer be normalized against the ACM's codec database. This not only breaks a couple of downstream tests (which I've written fixes for) but also runs the risk of breaking other external usage, like SDP mangling etc. Eventually, we should change to using the spelling from the relevant RFCs, although not as part of this other, large change. BUG=webrtc:5806 Review-Url: https://codereview.webrtc.org/2845603002 Cr-Commit-Position: refs/heads/master@{#17903} Committed: https://chromium.googlesource.com/external/webrtc/+/66753c34ad91d82919cefab13c08c28492c0a1a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M webrtc/media/base/mediaconstants.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/media/engine/payload_type_mapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
ossu
PTAL. I've verified that the printouts from WebRtcVoiceEngine is now using these spellings. That's probably ...
3 years, 8 months ago (2017-04-26 14:09:37 UTC) #4
kwiberg-webrtc
lgtm
3 years, 7 months ago (2017-04-26 16:45:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2845603002/1
3 years, 7 months ago (2017-04-27 08:44:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 08:47:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/66753c34ad91d82919cefab13...

Powered by Google App Engine
This is Rietveld 408576698