webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc - Issue 2845603002: Normalize codec names to those used by AcmCodecDatabase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc

Issue 2845603002: Normalize codec names to those used by AcmCodecDatabase. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc ('k') | webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc

diff --git a/webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc b/webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc

index 54345fd28b0e1c0034fbda243a3126f170dbd5cb..8e75fac081dd89ccf19ac851c3d9d3a52523a290 100644

--- a/webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc

+++ b/webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory.cc

@@ -87,10 +87,10 @@ class BuiltinAudioEncoderFactory : public AudioEncoderFactory {

std::vector<AudioCodecSpec> GetSupportedEncoders() override {

static const SdpAudioFormat desired_encoders[] = {

{"opus", 48000, 2, {{"minptime", "10"}, {"useinbandfec", "1"}}},

- {"isac", 16000, 1},

- {"isac", 32000, 1},

+ {"ISAC", 16000, 1},

+ {"ISAC", 32000, 1},

{"G722", 8000, 1},

- {"iLBC", 8000, 1},

+ {"ILBC", 8000, 1},

{"PCMU", 8000, 1},

{"PCMA", 8000, 1},

};