Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2844393002: Reland of Support adding and removing MediaRecorder to camera 2 session. (Closed)

Created:
3 years, 7 months ago by AlexG
Modified:
3 years, 7 months ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Support adding and removing MediaRecorder to camera 2 session. (patchset #1 id:1 of https://codereview.webrtc.org/2844233002/ ) Reason for revert: Revert "Revert of Support adding and removing MediaRecorder to camera 2 session. (patchset #5 id:80001 of https://codereview.webrtc.org/2833773003/ )" Will fix external bots by cherry picking this CL and updating external functions which depend on CameraVideoCapturer interface Original issue's description: > Revert of Support adding and removing MediaRecorder to camera 2 session. (patchset #5 id:80001 of https://codereview.webrtc.org/2833773003/ ) > > Reason for revert: > Breaks external bot > > Original issue's description: > > Support adding and removing MediaRecorder to camera 2 session. > > > > Camera 1 API is not supported. > > > > BUG=b/36684011 > > > > Review-Url: https://codereview.webrtc.org/2833773003 > > Cr-Commit-Position: refs/heads/master@{#17901} > > Committed: https://chromium.googlesource.com/external/webrtc/+/2fc04769faec0031a202963eaeb602420a082c07 > > TBR=sakal@webrtc.org,glaznev@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=b/36684011 > > Review-Url: https://codereview.webrtc.org/2844233002 > Cr-Commit-Position: refs/heads/master@{#17905} > Committed: https://chromium.googlesource.com/external/webrtc/+/6702739862e292f3556a9e63c71367f49c3895b4 TBR=sakal@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/36684011 Review-Url: https://codereview.webrtc.org/2844393002 Cr-Commit-Position: refs/heads/master@{#17915} Committed: https://chromium.googlesource.com/external/webrtc/+/37adc5e81e997634b60ff18f914332e10f6f3223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -40 lines) Patch
M webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/Camera2Capturer.java View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/CameraVideoCapturer.java View 2 chunks +28 lines, -0 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/Camera2CapturerTest.java View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java View 2 chunks +95 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/Camera2Session.java View 6 chunks +20 lines, -8 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/CameraCapturer.java View 13 chunks +147 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
AlexG
Created Reland of Support adding and removing MediaRecorder to camera 2 session.
3 years, 7 months ago (2017-04-27 20:38:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2844393002/1
3 years, 7 months ago (2017-04-27 20:38:24 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 20:38:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/37adc5e81e997634b60ff18f9...

Powered by Google App Engine
This is Rietveld 408576698