Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2844233002: Revert of Support adding and removing MediaRecorder to camera 2 session. (Closed)

Created:
3 years, 8 months ago by magjed_webrtc
Modified:
3 years, 8 months ago
Reviewers:
AlexG, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Support adding and removing MediaRecorder to camera 2 session. (patchset #5 id:80001 of https://codereview.webrtc.org/2833773003/ ) Reason for revert: Breaks external bot Original issue's description: > Support adding and removing MediaRecorder to camera 2 session. > > Camera 1 API is not supported. > > BUG=b/36684011 > > Review-Url: https://codereview.webrtc.org/2833773003 > Cr-Commit-Position: refs/heads/master@{#17901} > Committed: https://chromium.googlesource.com/external/webrtc/+/2fc04769faec0031a202963eaeb602420a082c07 TBR=sakal@webrtc.org,glaznev@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/36684011 Review-Url: https://codereview.webrtc.org/2844233002 Cr-Commit-Position: refs/heads/master@{#17905} Committed: https://chromium.googlesource.com/external/webrtc/+/6702739862e292f3556a9e63c71367f49c3895b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -308 lines) Patch
M webrtc/sdk/android/api/org/webrtc/Camera1Capturer.java View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/Camera2Capturer.java View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/CameraVideoCapturer.java View 2 chunks +0 lines, -28 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/Camera2CapturerTest.java View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java View 2 chunks +0 lines, -95 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/Camera2Session.java View 6 chunks +11 lines, -23 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/CameraCapturer.java View 13 chunks +21 lines, -145 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
magjed_webrtc
Created Revert of Support adding and removing MediaRecorder to camera 2 session.
3 years, 8 months ago (2017-04-27 09:34:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2844233002/1
3 years, 8 months ago (2017-04-27 09:34:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/6702739862e292f3556a9e63c71367f49c3895b4
3 years, 8 months ago (2017-04-27 09:34:25 UTC) #6
AlexG
3 years, 7 months ago (2017-04-27 20:38:21 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2844393002/ by glaznev@webrtc.org.

The reason for reverting is: Revert "Revert of Support adding and removing
MediaRecorder to camera 2 session. (patchset #5 id:80001 of
https://codereview.webrtc.org/2833773003/ )"

Will fix external bots by cherry picking this CL and updating external functions
which depend on CameraVideoCapturer interface.

Powered by Google App Engine
This is Rietveld 408576698