Fixing sigslot copy constructors.

Fixing sigslot copy constructors.

They used to work, but were broken by a somewhat recent refactoring of
sigslot.h.

It's reasonable for signals and slots to have copy constructors, since
a class that uses signals/slots may want to be copyable.

BUG=webrtc:7342
Review-Url: https://codereview.webrtc.org/2842423002
Cr-Commit-Position: refs/heads/master@{#17942}
Committed: https://chromium.googlesource.com/external/webrtc/+/8b1d862bfe6b8c160b0130e7d0b0444bcf668dd4

[Taylor Brandstetter, 2017-04-27 03:08:44]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-04-27 03:08:44]

Peter, can you take a look? It's a pretty small change, just restoring previous
code's behavior.

https://codereview.webrtc.org/2842423002/diff/1/webrtc/base/sigslot.h
File webrtc/base/sigslot.h (right):

https://codereview.webrtc.org/2842423002/diff/1/webrtc/base/sigslot.h#newcode529
webrtc/base/sigslot.h:529: {
I know indentation is messed up; I'm going to make another CL after this that
just runs clang-format.

[pthatcher1, 2017-04-29 00:13:42]

lgtm

[Taylor Brandstetter, 2017-04-29 04:11:43]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-04-29 04:11:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-29 04:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 04:22:24]

Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/18558)

[Taylor Brandstetter, 2017-04-29 07:05:42]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-04-29 07:05:42]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2842423002/#ps40001 (title:
"Fixing missing backreference from copied slot to signal.")

[commit-bot: I haz the power, 2017-04-29 07:05:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-29 07:27:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493449542494340,
"parent_rev": "12a467ffca82c8ddf138e5a0bdbf7db46663da63", "commit_rev":
"8b1d862bfe6b8c160b0130e7d0b0444bcf668dd4"}

[commit-bot: I haz the power, 2017-04-29 07:27:08]

Description was changed from

==========
Fixing sigslot copy constructors.

They used to work, but were broken by a somewhat recent refactoring of
sigslot.h.

It's reasonable for signals and slots to have copy constructors, since
a class that uses signals/slots may want to be copyable.

BUG=webrtc:7342
==========

to

==========
Fixing sigslot copy constructors.

They used to work, but were broken by a somewhat recent refactoring of
sigslot.h.

It's reasonable for signals and slots to have copy constructors, since
a class that uses signals/slots may want to be copyable.

BUG=webrtc:7342

Review-Url: https://codereview.webrtc.org/2842423002
Cr-Commit-Position: refs/heads/master@{#17942}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8b1d862bfe6b8c160b0130e7d...
==========

[commit-bot: I haz the power, 2017-04-29 07:27:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/8b1d862bfe6b8c160b0130e7d...

[perkj_webrtc, 2017-05-02 11:31:46]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2854053002/ by perkj@webrtc.org.

The reason for reverting is: This seems to cause a heap use after free issue in
Chrome:

XmppConnectionTest.ConnectThenError
XmppConnectionTest.RaisedError
XmppConnectionTest.FailureAfterPreAuth
XmppConnectionTest.PreAuthFailure
XmppConnectionTest.ImmediateFailure

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

[perkj_webrtc, 2017-05-02 13:16:37]

On 2017/05/02 11:31:46, perkj_webrtc wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.webrtc.org/2854053002/ by mailto:perkj@webrtc.org.
> 
> The reason for reverting is: This seems to cause a heap use after free issue
in
> Chrome:
> 
> XmppConnectionTest.ConnectThenError
> XmppConnectionTest.RaisedError
> XmppConnectionTest.FailureAfterPreAuth
> XmppConnectionTest.PreAuthFailure
> XmppConnectionTest.ImmediateFailure
> 
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

Turns out that this is the offending cl:
https://codereview.webrtc.org/2846593005