Fixing sigslot copy constructors.

webrtc/base/sigslot.h

 // sigslot.h: Signal/Slot classes
 //
 // Written by Sarah Thompson (sarah@telergy.com) 2002.
 //
 // License: Public domain. You are free to use this code however you like, with the proviso that
 //          the author takes on no responsibility or liability for any use.
 //
 // QUICK DOCUMENTATION
 //
 //                              (see also the full documentation at http://sigslot.sourceforge.net/)
@@ skipping 389 matching lines @@
 
                 ~_signal_base()
                 {
                         disconnect_all();
                 }
 
         private:
                 _signal_base& operator= (_signal_base const& that);
 
         public:
-                _signal_base(const _signal_base& s) : _signal_base_interface(&_signal_base::do_slot_disconnect, &_signal_base::do_slot_duplicate) {
+                _signal_base(const _signal_base& o) : _signal_base_interface(&_signal_base::do_slot_disconnect, &_signal_base::do_slot_duplicate) {
                         lock_block<mt_policy> lock(this);
-                        connections_list::const_iterator it = m_connected_slots.begin();
-                        connections_list::const_iterator itEnd = m_connected_slots.end();
-                        while(it != itEnd)
+      for (const auto& connection : o.m_connected_slots)
                         {
-                                it->getdest()->signal_connect(this);
-                                m_connected_slots.push_back(*it);
-                                ++it;
+                                connection.getdest()->signal_connect(this);
+                                m_connected_slots.push_back(connection);
                         }
                 }
 
                 bool is_empty()
                 {
                         lock_block<mt_policy> lock(this);
                         return m_connected_slots.empty();
                 }
 
                 void disconnect_all()
@@ skipping 92 matching lines @@
         {
         private:
                 typedef std::set< _signal_base_interface* > sender_set;
                 typedef sender_set::const_iterator const_iterator;
 
         public:
                 has_slots() : has_slots_interface(&has_slots::do_signal_connect, &has_slots::do_signal_disconnect, &has_slots::do_disconnect_all)
                 {
                 }
 
+                has_slots(has_slots const& o) : has_slots_interface(&has_slots::do_signal_connect, &has_slots::do_signal_disconnect, &has_slots::do_disconnect_all)
+    {

[Taylor Brandstetter, 2017/04/27 03:08:44]

I know indentation is messed up; I'm going to make another CL after this that
just runs clang-format.

+                        lock_block<mt_policy> lock(this);
+      for (auto* signal : o.m_senders) {
+        signal->slot_duplicate(&o, this);
+      }
+    }
+
                 ~has_slots()
                 {
                         this->disconnect_all();
                 }
 
         private:
-                has_slots(has_slots const&);
                 has_slots& operator= (has_slots const&);
 
                 static void do_signal_connect(has_slots_interface* p, _signal_base_interface* sender)
                 {
                         has_slots* const self = static_cast< has_slots* >(p);
                         lock_block<mt_policy> lock(self);
                         self->m_senders.insert(sender);
                 }
 
                 static void do_signal_disconnect(has_slots_interface* p, _signal_base_interface* sender)
@@ skipping 103 matching lines @@
 
         template<typename A1, typename A2, typename A3, typename A4, typename A5, typename A6, typename A7, typename mt_policy = SIGSLOT_DEFAULT_MT_POLICY>
         using signal7 = signal_with_thread_policy<mt_policy, A1, A2, A3, A4, A5, A6, A7>;
 
         template<typename A1, typename A2, typename A3, typename A4, typename A5, typename A6, typename A7, typename A8, typename mt_policy = SIGSLOT_DEFAULT_MT_POLICY>
         using signal8 = signal_with_thread_policy<mt_policy, A1, A2, A3, A4, A5, A6, A7, A8>;
 
 } // namespace sigslot
 
 #endif // WEBRTC_BASE_SIGSLOT_H__