Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2839883002: Use field_trial::IsEnabled for FlexFEC. (Closed)

Created:
3 years, 8 months ago by brandtr
Modified:
3 years, 8 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use field_trial::IsEnabled for FlexFEC. Also clarify some comments. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2839883002 Cr-Commit-Position: refs/heads/master@{#17875} Committed: https://chromium.googlesource.com/external/webrtc/+/dbb1be59ff12176ee4ec0c5ab4a0693748a1fc06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M webrtc/media/engine/internalencoderfactory.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
brandtr
Please take a look.
3 years, 8 months ago (2017-04-25 08:29:13 UTC) #2
magjed_webrtc
lgtm
3 years, 8 months ago (2017-04-25 08:45:04 UTC) #3
magjed_webrtc
lgtm lgtm
3 years, 8 months ago (2017-04-25 08:45:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2839883002/1
3 years, 8 months ago (2017-04-26 06:41:25 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 07:02:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dbb1be59ff12176ee4ec0c5ab...

Powered by Google App Engine
This is Rietveld 408576698