Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2839883002: Use field_trial::IsEnabled for FlexFEC. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/internalencoderfactory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index 7eb150bb6533a44f023076a3ce09841cf566bb78..65833873f68c0e1a6f76edf67cba5fede33405d6 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -43,10 +43,12 @@ using DegradationPreference = webrtc::VideoSendStream::DegradationPreference;
namespace cricket {
namespace {
// If this field trial is enabled, we will enable sending FlexFEC and disable
-// sending ULPFEC whenever the former has been negotiated. Receiving FlexFEC
-// is enabled whenever FlexFEC has been negotiated.
+// sending ULPFEC whenever the former has been negotiated.
+// FlexFEC can only be negotiated when the "flexfec-03" SDP codec is enabled,
+// which is done by enabling the "WebRTC-FlexFEC-03-Advertised" field trial; see
+// internalencoderfactory.cc.
bool IsFlexfecFieldTrialEnabled() {
- return webrtc::field_trial::FindFullName("WebRTC-FlexFEC-03") == "Enabled";
+ return webrtc::field_trial::IsEnabled("WebRTC-FlexFEC-03");
}
// If this field trial is enabled, we will report VideoContentType RTP extension
« no previous file with comments | « webrtc/media/engine/internalencoderfactory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698