Don't crash if STUN error message is missing ERROR-CODE attribute.

Don't crash if STUN error message is missing ERROR-CODE attribute.

This is something a well-behaving STUN server shouldn't do, but we shouldn't
crash if it does happen.

Also adding helper function for the common operation of extracting just
the error code out of a STUN packet.

BUG=chromium:708469
Review-Url: https://codereview.webrtc.org/2837133003
Cr-Commit-Position: refs/heads/master@{#17892}
Committed: https://chromium.googlesource.com/external/webrtc/+/996fc6bdb70c5e855fb8eb8fdde29640c028983c

[Taylor Brandstetter, 2017-04-25 00:50:44]

Description was changed from

==========
Don't crash if STUN error is missing ERROR-CODE attribute.

Also adding helper function for the common operation of extracting just
the error code out of a STUN packet.

BUG=chromium:708469
==========

to

==========
Don't crash if STUN error message is missing ERROR-CODE attribute.

This is something a well-behaving STUN server shouldn't do, but we shouldn't
crash if it does happen.

Also adding helper function for the common operation of extracting just
the error code out of a STUN packet.

BUG=chromium:708469
==========

[Taylor Brandstetter, 2017-04-25 00:51:03]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-04-25 00:51:03]

PTAL Peter

[pthatcher1, 2017-04-25 19:59:30]

lgtm

[Taylor Brandstetter, 2017-04-26 15:55:40]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-04-26 15:55:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-26 16:21:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493222140857750, "parent_rev":
"65881de6c81cf3f33b0f2f5f8f4a19716ee93fdc", "commit_rev":
"996fc6bdb70c5e855fb8eb8fdde29640c028983c"}

[commit-bot: I haz the power, 2017-04-26 16:21:26]

Description was changed from

==========
Don't crash if STUN error message is missing ERROR-CODE attribute.

This is something a well-behaving STUN server shouldn't do, but we shouldn't
crash if it does happen.

Also adding helper function for the common operation of extracting just
the error code out of a STUN packet.

BUG=chromium:708469
==========

to

==========
Don't crash if STUN error message is missing ERROR-CODE attribute.

This is something a well-behaving STUN server shouldn't do, but we shouldn't
crash if it does happen.

Also adding helper function for the common operation of extracting just
the error code out of a STUN packet.

BUG=chromium:708469

Review-Url: https://codereview.webrtc.org/2837133003
Cr-Commit-Position: refs/heads/master@{#17892}
Committed:
https://chromium.googlesource.com/external/webrtc/+/996fc6bdb70c5e855fb8eb8fd...
==========

[commit-bot: I haz the power, 2017-04-26 16:21:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/996fc6bdb70c5e855fb8eb8fd...