webrtc/p2p/base/stun.h - Issue 2837133003: Don't crash if STUN error message is missing ERROR-CODE attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/stun.h

Issue 2837133003: Don't crash if STUN error message is missing ERROR-CODE attribute. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/stun.h

diff --git a/webrtc/p2p/base/stun.h b/webrtc/p2p/base/stun.h

index ab200687f5ba4d8855730ade4dde2786c0354124..4ea45050cab4350c2d964dcb84e285665a25612e 100644

--- a/webrtc/p2p/base/stun.h

+++ b/webrtc/p2p/base/stun.h

@@ -156,6 +156,9 @@ class StunMessage {

// Gets these specific attribute values.

const StunErrorCodeAttribute* GetErrorCode() const;

+ // Returns the code inside the error code attribute, if present, and

+ // STUN_ERROR_GLOBAL_FAILURE otherwise.

+ int GetErrorCodeValue() const;

const StunUInt16ListAttribute* GetUnknownAttributes() const;

// Takes ownership of the specified attribute and adds it to the message.

« no previous file with comments | « webrtc/p2p/base/relayport.cc ('k') | webrtc/p2p/base/stun.cc » ('j') | no next file with comments »