Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2835263002: Revert of Removing test deps in webrtc/test/fuzzers (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Removing test deps in webrtc/test/fuzzers (patchset #1 id:1 of https://codereview.webrtc.org/2840523003/ ) Reason for revert: Breaks libfuzzer bot - you forgot to run that one :P https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%28Libfuzzer%29/builds/5571 Original issue's description: > Removing test deps in webrtc/test/fuzzers > > Targets in webrtc/test/fuzzers are used in chromium which includes WebRTC > with rtc_include_tests=false. > > We enabled 'gn check' on the webrtc/test directory and we have detected > that some dependencies were not tracked. These dependencies are on test > targets so we cannot add them in the dep list because this causes a > breakage in chromium. > > BUG=webrtc:7515 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2840523003 > Cr-Commit-Position: refs/heads/master@{#17844} > Committed: https://chromium.googlesource.com/external/webrtc/+/14b86d386460a759da1d5029cc09eda46330ea2b TBR=mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7515 Review-Url: https://codereview.webrtc.org/2835263002 Cr-Commit-Position: refs/heads/master@{#17846} Committed: https://chromium.googlesource.com/external/webrtc/+/d8868637eef6a11fa2c049e351ac2e24d1080008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Created Revert of Removing test deps in webrtc/test/fuzzers
3 years, 8 months ago (2017-04-24 18:31:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2835263002/1
3 years, 8 months ago (2017-04-24 18:31:13 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:31:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d8868637eef6a11fa2c049e35...

Powered by Google App Engine
This is Rietveld 408576698