Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2840523003: Removing test deps in webrtc/test/fuzzers (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing test deps in webrtc/test/fuzzers Targets in webrtc/test/fuzzers are used in chromium which includes WebRTC with rtc_include_tests=false. We enabled 'gn check' on the webrtc/test directory and we have detected that some dependencies were not tracked. These dependencies are on test targets so we cannot add them in the dep list because this causes a breakage in chromium. BUG=webrtc:7515 NOTRY=True Review-Url: https://codereview.webrtc.org/2840523003 Cr-Commit-Position: refs/heads/master@{#17844} Committed: https://chromium.googlesource.com/external/webrtc/+/14b86d386460a759da1d5029cc09eda46330ea2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mbonadei
I want to avoid to revert the precious work done on 'webrtc/base'. So I created ...
3 years, 7 months ago (2017-04-24 12:47:59 UTC) #1
mbonadei
3 years, 7 months ago (2017-04-24 12:48:09 UTC) #3
kjellander_webrtc
lgtm don't forget NOTRY=True if you're convinced not breaking with the current trybot set.
3 years, 7 months ago (2017-04-24 12:59:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2840523003/1
3 years, 7 months ago (2017-04-24 15:42:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/14b86d386460a759da1d5029cc09eda46330ea2b
3 years, 7 months ago (2017-04-24 15:44:20 UTC) #10
kjellander_webrtc
3 years, 7 months ago (2017-04-24 18:31:10 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2835263002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks libfuzzer bot - you forgot to run that one
:P

https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%28Li....

Powered by Google App Engine
This is Rietveld 408576698