DescriptionThis change fixes a crash issue in WindowCapturerWin. The issue and fix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/.
I am also considering whether we should move the
previous_size_ = frame->size();
window_size_map_[window_] = previous_size_;
into the true branch. But since this change needs to be merged into M58 and M59,
I would prefer to keep it as small as possible.
BUG=712615
Review-Url: https://codereview.webrtc.org/2835553002
Cr-Commit-Position: refs/heads/master@{#17799}
(cherry picked from commit d41af462fb11a4854e25a84bb0d27b8c3fdd5519)
Review-Url: https://codereview.webrtc.org/2834923002 .
Cr-Commit-Position: refs/branch-heads/59@{#2}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}
Committed: https://chromium.googlesource.com/external/webrtc/+/21721bc8741b27d8d932c0f463c0c17862225000
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|