Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2826703002: Revert of Remove rtc_p2p_unittests from ortc_unittests executable. (Closed)

Created:
3 years, 8 months ago by Taylor Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove rtc_p2p_unittests from ortc_unittests executable. (patchset #1 id:1 of https://codereview.webrtc.org/2820263004/ ) Reason for revert: Breaks checkdeps rules. Need to make a "p2p_test_utils" build target to include things like fakeicetransport.h. Original issue's description: > Remove rtc_p2p_unittests from ortc_unittests executable. > > These tests are already built into rtc_unittests; they shouldn't be > built into two test executables. > > BUG=None > TBR=kjellander@webrtc.org > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2820263004 > Cr-Commit-Position: refs/heads/master@{#17748} > Committed: https://chromium.googlesource.com/external/webrtc/+/fe9d38f5151c8a9da404efbbf373b3cb9a23c68c TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2826703002 Cr-Commit-Position: refs/heads/master@{#17749} Committed: https://chromium.googlesource.com/external/webrtc/+/19fd811736913b1a86abcaf909b554b8384a038c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/ortc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
Created Revert of Remove rtc_p2p_unittests from ortc_unittests executable.
3 years, 8 months ago (2017-04-18 18:11:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2826703002/1
3 years, 8 months ago (2017-04-18 18:11:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/19fd811736913b1a86abcaf909b554b8384a038c
3 years, 8 months ago (2017-04-18 18:11:40 UTC) #6
kjellander_webrtc
3 years, 8 months ago (2017-04-18 19:53:50 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698