Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2820263004
Cr-Commit-Position: refs/heads/master@{#17752}
Committed: https://chromium.googlesource.com/external/webrtc/+/59edb9298e55790a8a6ee17c52f508284c70f4b6

[Taylor Brandstetter, 2017-04-18 17:56:47]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-04-18 17:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-18 17:59:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492538207491530, "parent_rev":
"07cd1ba0234e2370f6311d615ad4074144dd1645", "commit_rev":
"fe9d38f5151c8a9da404efbbf373b3cb9a23c68c"}

[commit-bot: I haz the power, 2017-04-18 17:59:24]

Description was changed from

==========
Remove rtc_p2p_unittests from ortc_unittests executable.

These tests are already built into rtc_unittests; they shouldn't be
built into two test executables.

BUG=None
TBR=kjellander@webrtc.org
NOTRY=True
==========

to

==========
Remove rtc_p2p_unittests from ortc_unittests executable.

These tests are already built into rtc_unittests; they shouldn't be
built into two test executables.

BUG=None
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2820263004
Cr-Commit-Position: refs/heads/master@{#17748}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fe9d38f5151c8a9da404efbbf...
==========

[commit-bot: I haz the power, 2017-04-18 17:59:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fe9d38f5151c8a9da404efbbf...

[Taylor Brandstetter, 2017-04-18 18:11:18]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2826703002/ by deadbeef@webrtc.org.

The reason for reverting is: Breaks checkdeps rules. Need to make a
"p2p_test_utils" build target to include things like fakeicetransport.h..

[Taylor Brandstetter, 2017-04-18 18:11:50]

Description was changed from

==========
Remove rtc_p2p_unittests from ortc_unittests executable.

These tests are already built into rtc_unittests; they shouldn't be
built into two test executables.

BUG=None
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2820263004
Cr-Commit-Position: refs/heads/master@{#17748}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fe9d38f5151c8a9da404efbbf...
==========

to

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests executable.

These tests are already built into rtc_unittests; they shouldn't be
built into two test executables.

BUG=None
==========

[Taylor Brandstetter, 2017-04-18 18:33:13]

Description was changed from

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests executable.

These tests are already built into rtc_unittests; they shouldn't be
built into two test executables.

BUG=None
==========

to

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being run three
times. Fixed by creating a "p2p_test_utils" target that contains the test utils
that ortc_unittests and rtc_media_unittests depend on, but not the tests
themselves.

BUG=None
==========

[Taylor Brandstetter, 2017-04-18 18:33:31]

Description was changed from

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being run three
times. Fixed by creating a "p2p_test_utils" target that contains the test utils
that ortc_unittests and rtc_media_unittests depend on, but not the tests
themselves.

BUG=None
==========

to

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
==========

[Taylor Brandstetter, 2017-04-18 18:34:09]

Description was changed from

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
==========

to

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
TBR=kjellander@webrtc.org
==========

[kjellander_webrtc, 2017-04-18 19:53:17]

Ouch... I always run all the compile trybots when doing NOTRY=True, but it's of
course easy to be wise after-the-fact ;-)

[Taylor Brandstetter, 2017-04-18 22:31:08]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-04-18 22:31:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Taylor Brandstetter, 2017-04-18 22:31:51]

On 2017/04/18 19:53:17, kjellander_webrtc wrote:
> Ouch... I always run all the compile trybots when doing NOTRY=True, but it's
of
> course easy to be wise after-the-fact ;-)

It compiled locally so I thought I was ok. But I guess that doesn't run the
dependency checks?

[commit-bot: I haz the power, 2017-04-18 22:49:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492554668741870,
"parent_rev": "60c10cb92512d34d7c635b9aa752423505d34022", "commit_rev":
"59edb9298e55790a8a6ee17c52f508284c70f4b6"}

[commit-bot: I haz the power, 2017-04-18 22:49:13]

Description was changed from

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
TBR=kjellander@webrtc.org
==========

to

==========
Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests

These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2820263004
Cr-Commit-Position: refs/heads/master@{#17752}
Committed:
https://chromium.googlesource.com/external/webrtc/+/59edb9298e55790a8a6ee17c5...
==========

[commit-bot: I haz the power, 2017-04-18 22:49:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/59edb9298e55790a8a6ee17c5...

[kjellander_webrtc, 2017-04-19 05:38:12]

On 2017/04/18 22:31:51, Taylor Brandstetter wrote:
> On 2017/04/18 19:53:17, kjellander_webrtc wrote:
> > Ouch... I always run all the compile trybots when doing NOTRY=True, but it's
> of
> > course easy to be wise after-the-fact ;-)
> 
> It compiled locally so I thought I was ok. But I guess that doesn't run the
> dependency checks?

Check deps runs as part of PRESUBMIT.py, so it should be caught during upload.
Maybe it only checks files for the current platform (but I didn't think that was
the case).