Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2822153002: Remove rtcp::TransportFeedback::GetStatusVector/GetReceiveDeltas (Closed)

Created:
3 years, 8 months ago by danilchap
Modified:
3 years, 8 months ago
Reviewers:
philipel, elad.alon
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove rtcp::TransportFeedback::GetStatusVector/GetReceiveDeltas in favor of GetPacketStatusCount/GetReceivedPackets BUG=webrtc:5565 Review-Url: https://codereview.webrtc.org/2822153002 Cr-Commit-Position: refs/heads/master@{#17792} Committed: https://chromium.googlesource.com/external/webrtc/+/c1b693c7a84f7b3b9811f639d38fb12cc21cc644

Patch Set 1 #

Patch Set 2 : bit more simplifications #

Total comments: 2

Patch Set 3 : Delete instead of deprecate #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -53 lines) Patch
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 2 chunks +3 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h View 1 2 1 chunk +3 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
danilchap
3 years, 8 months ago (2017-04-18 16:51:39 UTC) #4
philipel
https://codereview.webrtc.org/2822153002/diff/60001/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h File webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h (right): https://codereview.webrtc.org/2822153002/diff/60001/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h#newcode67 webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h:67: RTC_DEPRECATED std::vector<TransportFeedback::StatusSymbol> GetStatusVector() Why don't we remove GetStatusVector, GetReceiveDeltas ...
3 years, 8 months ago (2017-04-19 12:34:59 UTC) #5
danilchap
https://codereview.webrtc.org/2822153002/diff/60001/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h File webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h (right): https://codereview.webrtc.org/2822153002/diff/60001/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h#newcode67 webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h:67: RTC_DEPRECATED std::vector<TransportFeedback::StatusSymbol> GetStatusVector() On 2017/04/19 12:34:59, philipel wrote: > ...
3 years, 8 months ago (2017-04-19 14:05:35 UTC) #7
philipel
lgtm
3 years, 8 months ago (2017-04-20 09:03:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2822153002/100001
3 years, 8 months ago (2017-04-20 15:01:27 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:23:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/c1b693c7a84f7b3b9811f639d...

Powered by Google App Engine
This is Rietveld 408576698