Remove rtcp::TransportFeedback::GetStatusVector/GetReceiveDeltas

webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TRANSPORT_FEEDBACK_H_
 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TRANSPORT_FEEDBACK_H_
 
 #include <memory>
 #include <vector>
 
+#include "webrtc/base/deprecation.h"
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h"
 
 namespace webrtc {
 namespace rtcp {
 class CommonHeader;
 
 class TransportFeedback : public Rtpfb {
  public:
   class ReceivedPacket {
    public:
@@ skipping 27 matching lines @@
   bool AddReceivedPacket(uint16_t sequence_number, int64_t timestamp_us);
   const std::vector<ReceivedPacket>& GetReceivedPackets() const;
 
   enum class StatusSymbol {
     kNotReceived,
     kReceivedSmallDelta,
     kReceivedLargeDelta,
   };
 
   uint16_t GetBaseSequence() const;
-  std::vector<TransportFeedback::StatusSymbol> GetStatusVector() const;
-  std::vector<int16_t> GetReceiveDeltas() const;
+  // Returns number of packets (including missing) this feedback describes.
+  size_t GetPacketStatusCount() const { return num_seq_no_; }
+  RTC_DEPRECATED std::vector<TransportFeedback::StatusSymbol> GetStatusVector()

[philipel, 2017/04/19 12:34:59]

Why don't we remove GetStatusVector, GetReceiveDeltas and GetReceiveDeltasUs?

[danilchap, 2017/04/19 14:05:35]

No good reason.
Done

+      const;
+  RTC_DEPRECATED std::vector<int16_t> GetReceiveDeltas() const;
 
   // Get the reference time in microseconds, including any precision loss.
   int64_t GetBaseTimeUs() const;
   // Convenience method for getting all deltas as microseconds. The first delta
   // is relative the base time.
-  std::vector<int64_t> GetReceiveDeltasUs() const;
+  RTC_DEPRECATED std::vector<int64_t> GetReceiveDeltasUs() const;
 
   bool Parse(const CommonHeader& packet);
   static std::unique_ptr<TransportFeedback> ParseFrom(const uint8_t* buffer,
                                                       size_t length);
   // Pre and postcondition for all public methods. Should always return true.
   // This function is for tests.
   bool IsConsistent() const;
 
  protected:
   bool Create(uint8_t* packet,
@@ skipping 24 matching lines @@
   std::vector<ReceivedPacket> packets_;
   // All but last encoded packet chunks.
   std::vector<uint16_t> encoded_chunks_;
   const std::unique_ptr<LastChunk> last_chunk_;
   size_t size_bytes_;
 };
 
 }  // namespace rtcp
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TRANSPORT_FEEDBACK_H_