Reland "Add first part of the network_tester functionality".

Reland "Add first part of the network_tester functionality".

This was originally proposed in https://codereview.webrtc.org/2779233002, but due to upstreaming errors, reverted and relanded a few times. This is a tested reland of it.

BUG=webrtc:7426
Review-Url: https://codereview.webrtc.org/2821133004
Cr-Commit-Position: refs/heads/master@{#17756}
Committed: https://chromium.googlesource.com/external/webrtc/+/939df965006514c68d6590c7fc3c2a338f07b90d

[minyue-webrtc, 2017-04-18 13:27:55]

Description was changed from

==========
Reland "Add first part of the network_tester functionality".

This reverts commit 345dffdec17a273f00f6bf7a70d7307006327734.

BUG=
==========

to

==========
Reland "Add first part of the network_tester functionality".

This was originally proposed in https://codereview.webrtc.org/2779233002, but
due to upstreaming errors, reverted and relanded a few times. This is a tested
reland of it.

BUG=webrtc:7426
==========

[minyue-webrtc, 2017-04-18 13:27:55]

minyue@webrtc.org changed reviewers:
+ kjellander@webrtc.org, mbonadei@webrtc.org, michaelt@webrtc.org

[minyue-webrtc, 2017-04-18 13:28:14]

PTAL, thanks!

[minyue-webrtc, 2017-04-18 13:28:21]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:28:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[mbonadei, 2017-04-18 13:31:13]

On 2017/04/18 13:28:14, minyue-webrtc wrote:
> PTAL, thanks!

lgtm.

[kjellander_webrtc, 2017-04-18 13:39:38]

https://codereview.webrtc.org/2821133004/diff/20001/webrtc/tools/network_test...
File webrtc/tools/network_tester/BUILD.gn (right):

https://codereview.webrtc.org/2821133004/diff/20001/webrtc/tools/network_test...
webrtc/tools/network_tester/BUILD.gn:86: "WEBRTC_NETWORK_TESTER_TEST_ENABLED",
We don't want this to always be set, we need a way to make it not be set as
well.

Please create a declare_args() section at the top of this file, like this:

declare_args()  {
  # Make it possible to disable the network tester test.
  rtc_enable_network_tester_test = true
}

Then in this target, have a line like this:
if (rtc_enable_network_tester_test) {
  defines += ["WEBRTC_NETWORK_TESTER_TEST_ENABLED"]
}

[kjellander_webrtc, 2017-04-18 13:45:23]

lgtm

https://codereview.webrtc.org/2821133004/diff/20001/webrtc/tools/network_test...
File webrtc/tools/network_tester/BUILD.gn (right):

https://codereview.webrtc.org/2821133004/diff/20001/webrtc/tools/network_test...
webrtc/tools/network_tester/BUILD.gn:86: "WEBRTC_NETWORK_TESTER_TEST_ENABLED",
On 2017/04/18 13:39:37, kjellander_webrtc wrote:
> We don't want this to always be set, we need a way to make it not be set as
> well.
> 
> Please create a declare_args() section at the top of this file, like this:
> 
> declare_args()  {
>   # Make it possible to disable the network tester test.
>   rtc_enable_network_tester_test = true
> }
> 
> Then in this target, have a line like this:
> if (rtc_enable_network_tester_test) {
>   defines += ["WEBRTC_NETWORK_TESTER_TEST_ENABLED"]
> } 

I changed my mind. This is fine with me since we can use this just as easily
downstream.

[michaelt, 2017-04-18 13:48:57]

lgtm

[commit-bot: I haz the power, 2017-04-18 14:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 14:22:42]

Dry run: This issue passed the CQ dry run.

[minyue-webrtc, 2017-04-19 08:56:02]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2017-04-19 08:56:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-19 08:58:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492592162653580,
"parent_rev": "05843312195912a0fab761702991f5041aba9be3", "commit_rev":
"939df965006514c68d6590c7fc3c2a338f07b90d"}

[commit-bot: I haz the power, 2017-04-19 08:58:41]

Description was changed from

==========
Reland "Add first part of the network_tester functionality".

This was originally proposed in https://codereview.webrtc.org/2779233002, but
due to upstreaming errors, reverted and relanded a few times. This is a tested
reland of it.

BUG=webrtc:7426
==========

to

==========
Reland "Add first part of the network_tester functionality".

This was originally proposed in https://codereview.webrtc.org/2779233002, but
due to upstreaming errors, reverted and relanded a few times. This is a tested
reland of it.

BUG=webrtc:7426

Review-Url: https://codereview.webrtc.org/2821133004
Cr-Commit-Position: refs/heads/master@{#17756}
Committed:
https://chromium.googlesource.com/external/webrtc/+/939df965006514c68d6590c7f...
==========

[commit-bot: I haz the power, 2017-04-19 08:58:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/939df965006514c68d6590c7f...