Add first part of the network_tester functionality.

Add first part of the network_tester functionality.

BUG=webrtc:7426
Review-Url: https://codereview.webrtc.org/2779233002
Cr-Commit-Position: refs/heads/master@{#17635}
Committed: https://chromium.googlesource.com/external/webrtc/+/333d0ff63173f2561fb03b323080e5f8b1c71dc4

[michaelt, 2017-03-29 10:59:45]

Description was changed from

==========
Add first part of the network_tester functionality.

BUG=
==========

to

==========
Add first part of the network_tester functionality.

BUG=
==========

[michaelt, 2017-03-29 10:59:45]

michaelt@webrtc.org changed reviewers:
+ minyue@webrtc.org, stefan@webrtc.org

[michaelt, 2017-03-29 11:00:38]

Hi here the fist part of the network tester.

[stefan-webrtc, 2017-03-30 07:47:17]

stefan@webrtc.org changed reviewers:
+ nisse@webrtc.org

[stefan-webrtc, 2017-03-30 07:47:18]

Adding nisse as a reviewer for this.

Nisse, can you help out reviewing the work on this tool? I'll share a doc we
have around it separately which should give you details on what we try to
achieve.

[stefan-webrtc, 2017-03-30 07:48:53]

Michael, maybe it would be a good idea to file a bug and refer to this?

File it under the BWE component on bugs.webrtc.org

[michaelt, 2017-03-30 07:56:08]

Description was changed from

==========
Add first part of the network_tester functionality.

BUG=
==========

to

==========
Add first part of the network_tester functionality.

BUG=webrtc:7426
==========

[stefan-webrtc, 2017-03-30 07:56:53]

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
File webrtc/tools/network_tester/config_reader.h (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
webrtc/tools/network_tester/config_reader.h:34:
RTC_DISALLOW_COPY_AND_ASSIGN(ConfigReader);
Empty line above this

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
File webrtc/tools/network_tester/create_network_tester_config.py (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
webrtc/tools/network_tester/create_network_tester_config.py:22:
network_configs.append(CreateTesterConfig(10, 100 , 200))
Remove space after 100: "100 ,"
Same for "50 ,"

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.cc:104:
packet.set_send_timestamp(rtc::TimeMicros());
You could also grab this from the SignalSentPacket signal. That would be more
accurate since we avoid issues where we have to wait when hopping between
threads.

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.h (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.h:56:
RTC_DISALLOW_COPY_AND_ASSIGN(PacketSender);
Empty line above.

[michaelt, 2017-03-30 08:29:27]

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
File webrtc/tools/network_tester/config_reader.h (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
webrtc/tools/network_tester/config_reader.h:34:
RTC_DISALLOW_COPY_AND_ASSIGN(ConfigReader);
On 2017/03/30 07:56:53, stefan-webrtc wrote:
> Empty line above this

Done.

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
File webrtc/tools/network_tester/create_network_tester_config.py (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/c...
webrtc/tools/network_tester/create_network_tester_config.py:22:
network_configs.append(CreateTesterConfig(10, 100 , 200))
On 2017/03/30 07:56:53, stefan-webrtc wrote:
> Remove space after 100: "100 ,"
> Same for "50 ,"

Done.

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.cc:104:
packet.set_send_timestamp(rtc::TimeMicros());
On 2017/03/30 07:56:53, stefan-webrtc wrote:
> You could also grab this from the SignalSentPacket signal. That would be more
> accurate since we avoid issues where we have to wait when hopping between
> threads.
Isn't the packet already sent on SignalSentPacket ?

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.h (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.h:56:
RTC_DISALLOW_COPY_AND_ASSIGN(PacketSender);
On 2017/03/30 07:56:53, stefan-webrtc wrote:
> Empty line above.

Done.

[stefan-webrtc, 2017-03-30 09:20:31]

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.cc:104:
packet.set_send_timestamp(rtc::TimeMicros());
On 2017/03/30 08:29:26, michaelt wrote:
> On 2017/03/30 07:56:53, stefan-webrtc wrote:
> > You could also grab this from the SignalSentPacket signal. That would be
more
> > accurate since we avoid issues where we have to wait when hopping between
> > threads.
> Isn't the packet already sent on SignalSentPacket ? 

It is signaled once the socket has sent the packet, and should better represent
when the packet "hits the wire".

[michaelt, 2017-03-30 09:31:04]

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.cc:104:
packet.set_send_timestamp(rtc::TimeMicros());
In the current impl. I have to set the send time in packet which is send.
So i can't set it after it is sent.

[terelius, 2017-03-30 09:31:22]

terelius@webrtc.org changed reviewers:
+ terelius@webrtc.org

[terelius, 2017-03-30 09:31:23]

https://codereview.webrtc.org/2779233002/diff/20001/webrtc/tools/network_test...
File webrtc/tools/network_tester/BUILD.gn (right):

https://codereview.webrtc.org/2779233002/diff/20001/webrtc/tools/network_test...
webrtc/tools/network_tester/BUILD.gn:22: "network_tester_packet.proto",
Are the proto files added in another CL?

[stefan-webrtc, 2017-03-30 09:42:22]

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/1/webrtc/tools/network_tester/p...
webrtc/tools/network_tester/packet_sender.cc:104:
packet.set_send_timestamp(rtc::TimeMicros());
On 2017/03/30 09:31:03, michaelt wrote:
> In the current impl. I have to set the send time in packet which is send.
> So i can't set it after it is sent.

I see, probably good enough anyway since the app is so simple.

[michaelt, 2017-03-30 09:52:40]

https://codereview.webrtc.org/2779233002/diff/20001/webrtc/tools/network_test...
File webrtc/tools/network_tester/BUILD.gn (right):

https://codereview.webrtc.org/2779233002/diff/20001/webrtc/tools/network_test...
webrtc/tools/network_tester/BUILD.gn:22: "network_tester_packet.proto",
On 2017/03/30 09:31:23, terelius wrote:
> Are the proto files added in another CL?

I just missed to add them :)

[terelius, 2017-03-30 11:33:42]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_packet.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_packet.proto:13: required Type type =
1;
While I don't have a strong opinion, please be aware that the "required" keyword
is *very* controversial. The basic problem is that required fields can't be
added or removed without breaking all old clients, which makes it hard to
maintain code once it has reached production. The standard way to avoid this is
to make all fields optional and write custom validation code.

The keywords "optional" and "required" keywords have been removed in proto3 for
this very reason.

[minyue-webrtc, 2017-04-03 08:05:20]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/config_reader.cc (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/config_reader.cc:32: RTC_DCHECK(0 <= byte && byte <=
255);
nit
RTC_DCHECK_LE
RTC_DCHECK_GE
for better error message

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_config.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_config.proto:9: }
Maybe you want to add

message NetworkTesterAllConfigs {
  repeated NetworkTesterConfig;
}

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_packet.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_packet.proto:7: HI = 0;
HI -> HAND_SHAKING / TEST_START?

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:10: #include
"webrtc/tools/network_tester/packet_sender.h"
nit: add a line between 9 and 10

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:40: PacketSender* packet_sender_;
const?

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:64: PacketSender* packet_sender_;
const?

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:67: }  // namespace
nit: an empty line between 66 and 67

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/test_controller.h (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/test_controller.h:66: std::array<char, 15000>
send_data_;
15000? Preferably not hard coded here

[minyue-webrtc, 2017-04-03 08:09:51]

one additional question

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/test_controller.h (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/test_controller.h:36: class TestController : public
sigslot::has_slots<> {
I don't quite understand why sigslot::has_slots<> is needed

[michaelt, 2017-04-03 13:05:39]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/config_reader.cc (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/config_reader.cc:32: RTC_DCHECK(0 <= byte && byte <=
255);
On 2017/04/03 08:05:19, minyue-webrtc wrote:
> nit
> RTC_DCHECK_LE
> RTC_DCHECK_GE
> for better error message

Done.

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_packet.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_packet.proto:7: HI = 0;
On 2017/04/03 08:05:19, minyue-webrtc wrote:
> HI -> HAND_SHAKING / TEST_START?

Done.

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_packet.proto:13: required Type type =
1;
Ok will make this optional as well an check it in the code.

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/packet_sender.cc (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:10: #include
"webrtc/tools/network_tester/packet_sender.h"
On 2017/04/03 08:05:20, minyue-webrtc wrote:
> nit: add a line between 9 and 10

Done.

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:40: PacketSender* packet_sender_;
I can make the pointer const but not the object

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:64: PacketSender* packet_sender_;
I can make the pointer const but not the object

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.cc:67: }  // namespace
On 2017/04/03 08:05:20, minyue-webrtc wrote:
> nit: an empty line between 66 and 67

Done.

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/test_controller.h (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/test_controller.h:36: class TestController : public
sigslot::has_slots<> {
TestController register itself in socket as a receiver of a signal.
So it have to inherent from sigslot::has_slots.

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/test_controller.h:66: std::array<char, 15000>
send_data_;
On 2017/04/03 08:05:20, minyue-webrtc wrote:
> 15000? Preferably not hard coded here

Done.

[minyue-webrtc, 2017-04-04 09:08:01]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_config.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_config.proto:9: }
On 2017/04/03 08:05:19, minyue-webrtc wrote:
> Maybe you want to add
> 
> message NetworkTesterAllConfigs {
>   repeated NetworkTesterConfig;
> }

Any reply?

[michaelt, 2017-04-04 09:18:45]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_config.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_config.proto:9: }
Oops i missed that one.
At the moment I do the serializations by hand (same way as in debug dump). For
this case "repeated" would probably work as well, since i don't expect to have
such a huge config that it will not fit in to the memory. Would you prefer, to
realize this with "repeated" ?

[minyue-webrtc, 2017-04-04 09:24:34]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_config.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_config.proto:9: }
On 2017/04/04 09:18:45, michaelt wrote:
> Oops i missed that one.
> At the moment I do the serializations by hand (same way as in debug dump). For
> this case "repeated" would probably work as well, since i don't expect to have
> such a huge config that it will not fit in to the memory. Would you prefer, to
> realize this with "repeated" ?

That's way I suggested an overall config. That may make your parser a lot
easier.

[michaelt, 2017-04-04 09:29:38]

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
File webrtc/tools/network_tester/network_tester_config.proto (right):

https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
webrtc/tools/network_tester/network_tester_config.proto:9: }
I still would need get the configs one by one.  But you are right we could
simplify the config_reader

[stefan-webrtc, 2017-04-05 07:46:53]

Two nits around thread checkers. Otherwise this lgtm

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
File webrtc/tools/network_tester/packet_sender.h (right):

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.h:49: rtc::TaskQueue worker_queue_;
Perhaps also use a SeqeuenceChecker to document where things are called?

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
File webrtc/tools/network_tester/test_controller.h (right):

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
webrtc/tools/network_tester/test_controller.h:61: private:
Should we just for completeness add some thread checkers to this class to
document what threads are in play?

[michaelt, 2017-04-05 10:14:45]

On 2017/04/04 09:24:34, minyue-webrtc wrote:
>
https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
> File webrtc/tools/network_tester/network_tester_config.proto (right):
> 
>
https://codereview.webrtc.org/2779233002/diff/40001/webrtc/tools/network_test...
> webrtc/tools/network_tester/network_tester_config.proto:9: }
> On 2017/04/04 09:18:45, michaelt wrote:
> > Oops i missed that one.
> > At the moment I do the serializations by hand (same way as in debug dump).
For
> > this case "repeated" would probably work as well, since i don't expect to
have
> > such a huge config that it will not fit in to the memory. Would you prefer,
to
> > realize this with "repeated" ?
> 
> That's way I suggested an overall config. That may make your parser a lot
> easier.

Done

[michaelt, 2017-04-05 10:15:31]

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
File webrtc/tools/network_tester/packet_sender.h (right):

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
webrtc/tools/network_tester/packet_sender.h:49: rtc::TaskQueue worker_queue_;
On 2017/04/05 07:46:53, stefan-webrtc wrote:
> Perhaps also use a SeqeuenceChecker to document where things are called?

Done.

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
File webrtc/tools/network_tester/test_controller.h (right):

https://codereview.webrtc.org/2779233002/diff/60001/webrtc/tools/network_test...
webrtc/tools/network_tester/test_controller.h:61: private:
On 2017/04/05 07:46:53, stefan-webrtc wrote:
> Should we just for completeness add some thread checkers to this class to
> document what threads are in play?

Done.

[minyue-webrtc, 2017-04-06 10:11:20]

lgtm

[michaelt, 2017-04-06 12:27:57]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 12:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-06 12:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 12:30:14]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/23646)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/20516)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/24593)

[michaelt, 2017-04-06 13:33:08]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 13:33:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-06 13:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 13:38:55]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15841)

[michaelt, 2017-04-06 14:32:01]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 14:32:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-06 14:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 14:37:37]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15845)

[michaelt, 2017-04-10 09:06:02]

Patchset #10 (id:180001) has been deleted

[michaelt, 2017-04-10 09:33:44]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 09:33:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 09:44:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 09:44:02]

Dry run: Try jobs failed on following builders:
  linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)

[michaelt, 2017-04-10 11:59:21]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 11:59:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 12:28:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 12:28:56]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/21648)

[michaelt, 2017-04-10 13:16:56]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:17:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 13:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:32:20]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/24723)

[michaelt, 2017-04-10 14:57:38]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 14:57:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 17:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:19:30]

Dry run: This issue passed the CQ dry run.

[michaelt, 2017-04-11 06:23:33]

The CQ bit was checked by michaelt@webrtc.org

[michaelt, 2017-04-11 06:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2779233002/#ps260001 (title:
"Try to fix tsan test.")

[commit-bot: I haz the power, 2017-04-11 06:23:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-11 06:26:36]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1491891813393160,
"parent_rev": "e0ab0ad85d5e8a6a83584c8d24762c5508294448", "commit_rev":
"333d0ff63173f2561fb03b323080e5f8b1c71dc4"}

[commit-bot: I haz the power, 2017-04-11 06:26:39]

Description was changed from

==========
Add first part of the network_tester functionality.

BUG=webrtc:7426
==========

to

==========
Add first part of the network_tester functionality.

BUG=webrtc:7426

Review-Url: https://codereview.webrtc.org/2779233002
Cr-Commit-Position: refs/heads/master@{#17635}
Committed:
https://chromium.googlesource.com/external/webrtc/+/333d0ff63173f2561fb03b323...
==========

[commit-bot: I haz the power, 2017-04-11 06:26:40]

Committed patchset #13 (id:260001) as
https://chromium.googlesource.com/external/webrtc/+/333d0ff63173f2561fb03b323...

[michaelt, 2017-04-11 07:16:36]

A revert of this CL (patchset #13 id:260001) has been created in
https://codereview.webrtc.org/2800403003/ by michaelt@webrtc.org.

The reason for reverting is: Tasn test failure. .