webrtc/tools/network_tester/network_tester_config.proto - Issue 2779233002: Add first part of the network_tester functionality.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/tools/network_tester/network_tester_config.proto

Issue 2779233002: Add first part of the network_tester functionality. (Closed)

Patch Set: Add proto files Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/tools/network_tester/config_reader.cc ('K') | « webrtc/tools/network_tester/create_network_tester_config.py ('k') | webrtc/tools/network_tester/network_tester_packet.proto » ('j') | webrtc/tools/network_tester/network_tester_packet.proto » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 syntax = "proto2";

	2 option optimize_for = LITE_RUNTIME;

	3 package webrtc.network_tester.config;

	4

	5 message NetworkTesterConfig {

	6 optional int32 packet_send_interval_ms = 1;

	7 optional float packet_size = 2;

	8 optional int32 execution_time_ms = 3;

	9 }
	minyue-webrtc 2017/04/03 08:05:19 Maybe you want to add message NetworkTesterAllCon Maybe you want to add message NetworkTesterAllConfigs { repeated NetworkTesterConfig; } minyue-webrtc 2017/04/04 09:08:01 Any reply? Show quoted text On 2017/04/03 08:05:19, minyue-webrtc wrote: > Maybe you want to add > > message NetworkTesterAllConfigs { > repeated NetworkTesterConfig; > } Any reply? michaelt 2017/04/04 09:18:45 Oops i missed that one. At the moment I do the ser Oops i missed that one. At the moment I do the serializations by hand (same way as in debug dump). For this case "repeated" would probably work as well, since i don't expect to have such a huge config that it will not fit in to the memory. Would you prefer, to realize this with "repeated" ? minyue-webrtc 2017/04/04 09:24:34 That's way I suggested an overall config. That may Show quoted text On 2017/04/04 09:18:45, michaelt wrote: > Oops i missed that one. > At the moment I do the serializations by hand (same way as in debug dump). For > this case "repeated" would probably work as well, since i don't expect to have > such a huge config that it will not fit in to the memory. Would you prefer, to > realize this with "repeated" ? That's way I suggested an overall config. That may make your parser a lot easier. michaelt 2017/04/04 09:29:37 I still would need get the configs one by one. Bu I still would need get the configs one by one. But you are right we could simplify the config_reader
OLD	NEW