Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2819473004: base/testutils.h: Use namespace webrtc::testing instead of plain testing (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

base/testutils.h: Use namespace webrtc::testing instead of plain testing We shouldn't pollute the global namespace. BUG=webrtc:7484 Review-Url: https://codereview.webrtc.org/2819473004 Cr-Commit-Position: refs/heads/master@{#17735} Committed: https://chromium.googlesource.com/external/webrtc/+/d0d81485f2c9a307c5a9b404050d20a5f56b3b52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -141 lines) Patch
M webrtc/base/httpbase_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/httpserver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/physicalsocketserver_unittest.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M webrtc/base/socket_unittest.cc View 33 chunks +73 lines, -68 lines 0 comments Download
M webrtc/base/testutils.h View 3 chunks +14 lines, -11 lines 0 comments Download
M webrtc/base/virtualsocket_unittest.cc View 22 chunks +56 lines, -49 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
kwiberg-webrtc
3 years, 8 months ago (2017-04-13 12:10:46 UTC) #9
tommi
lgtm
3 years, 8 months ago (2017-04-18 09:40:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2819473004/20001
3 years, 8 months ago (2017-04-18 09:42:52 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 10:18:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d0d81485f2c9a307c5a9b4040...

Powered by Google App Engine
This is Rietveld 408576698