Enabling 'gn check' on webrtc/sdk

webrtc/sdk/BUILD.gn

Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index d8e745c83f64a935469d800fe0c885bdd1bafdf8..593f4dab3f531f40dbebf9839d74d66ea6d8597d 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -30,6 +30,8 @@ if (is_ios || is_mac) {
   rtc_static_library("rtc_sdk_common_objc") {
     deps = [
       "../base:rtc_base",
+      "../system_wrappers:field_trial_default",

[kjellander_webrtc, 2017/04/12 14:37:04]

I suspect this might cause problems for consumers of the target that wants to
provide their own implementations. Which files are pulling these in? Can we
refactor out what they're referencing so we don't have to depend on the
implementations?

I'd like Magnus' input on this.

[mbonadei, 2017/04/13 08:12:03]

The header 'system_wrappers/include/field_trial_default.h' is pulled in by
'webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm' and
'webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h'.

+      "../system_wrappers:metrics_default",
     ]
     configs += [
       "..:common_objc",
@@ -73,6 +75,7 @@ if (is_ios || is_mac) {
           "objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm",
           "objc/Framework/Classes/Metal/RTCMTLVideoView.m",
         ]
+        deps += [ "../api:video_frame_api" ]
       }
 
       libs = [ "AVFoundation.framework" ]
@@ -198,6 +201,13 @@ if (is_ios || is_mac) {
 
     deps = [
       ":webrtc_h264_video_toolbox",
+      "../api:video_frame_api",
+      "../base:rtc_base",
+      "../base:rtc_base_approved",
+      "../common_video:common_video",
+      "../media:rtc_media",
+      "../media:rtc_media_base",
+      "../system_wrappers:system_wrappers",
     ]
 
     if (is_ios) {
@@ -280,6 +290,7 @@ if (is_ios || is_mac) {
       }
       deps = [
         ":rtc_sdk_peerconnection_objc",
+        "../base:rtc_base_tests_utils",
         "//third_party/ocmock",
         "//webrtc/system_wrappers:system_wrappers_default",
       ]
@@ -415,6 +426,13 @@ if (is_ios || is_mac) {
 
     deps = [
       ":rtc_sdk_common_objc",
+      "../api:video_frame_api",
+      "../base:rtc_base_approved",
+      "../common_video:common_video",

[kjellander_webrtc, 2017/04/12 14:37:04]

Leave out :common_video here for improved readability. Same earlier in the file.

[mbonadei, 2017/04/13 08:12:03]

Done.

+      "../media:rtc_media_base",
+      "../modules/video_coding:video_coding_utility",
+      "../modules/video_coding:webrtc_h264",
+      "../system_wrappers:system_wrappers",

[kjellander_webrtc, 2017/04/12 14:37:04]

You can leave out the :system_wrappers part.

[mbonadei, 2017/04/13 08:12:03]

Done.

     ]
 
     libs = [