Enabling 'gn check' on webrtc/sdk

webrtc/sdk/BUILD.gn

 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 if (is_ios) {
@@ skipping 12 matching lines @@
   config("rtc_sdk_common_objc_config") {
     include_dirs = [
       "objc/Framework/Classes",
       "objc/Framework/Headers",
     ]
   }
 
   rtc_static_library("rtc_sdk_common_objc") {
     deps = [
       "../base:rtc_base",
+      "../system_wrappers:field_trial_default",

[kjellander_webrtc, 2017/04/12 14:37:04]

I suspect this might cause problems for consumers of the target that wants to
provide their own implementations. Which files are pulling these in? Can we
refactor out what they're referencing so we don't have to depend on the
implementations?

I'd like Magnus' input on this.

[mbonadei, 2017/04/13 08:12:03]

The header 'system_wrappers/include/field_trial_default.h' is pulled in by
'webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm' and
'webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h'.

+      "../system_wrappers:metrics_default",
     ]
     configs += [
       "..:common_objc",
       "//build/config/compiler:enable_arc",
     ]
     public_configs = [ ":rtc_sdk_common_objc_config" ]
     sources = [
       "objc/Framework/Classes/NSString+StdString.h",
       "objc/Framework/Classes/NSString+StdString.mm",
       "objc/Framework/Classes/RTCDispatcher.m",
@@ skipping 23 matching lines @@
         "objc/Framework/Classes/UIDevice+RTCDevice.mm",
         "objc/Framework/Headers/WebRTC/RTCCameraPreviewView.h",
         "objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
       ]
       if (current_cpu == "arm64") {
         sources += [
           "objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h",
           "objc/Framework/Classes/Metal/RTCMTLNV12Renderer.mm",
           "objc/Framework/Classes/Metal/RTCMTLVideoView.m",
         ]
+        deps += [ "../api:video_frame_api" ]
       }
 
       libs = [ "AVFoundation.framework" ]
       if (current_cpu == "arm64") {
         libs += [
           "CoreVideo.framework",
           "Metal.framework",
           "MetalKit.framework",
         ]
       }
@@ skipping 105 matching lines @@
       "objc/Framework/Headers/WebRTC/RTCSessionDescription.h",
       "objc/Framework/Headers/WebRTC/RTCVideoCapturer.h",
       "objc/Framework/Headers/WebRTC/RTCVideoFrame.h",
       "objc/Framework/Headers/WebRTC/RTCVideoRenderer.h",
       "objc/Framework/Headers/WebRTC/RTCVideoSource.h",
       "objc/Framework/Headers/WebRTC/RTCVideoTrack.h",
     ]
 
     deps = [
       ":webrtc_h264_video_toolbox",
+      "../api:video_frame_api",
+      "../base:rtc_base",
+      "../base:rtc_base_approved",
+      "../common_video:common_video",
+      "../media:rtc_media",
+      "../media:rtc_media_base",
+      "../system_wrappers:system_wrappers",
     ]
 
     if (is_ios) {
       sources += [
         "objc/Framework/Classes/RTCEAGLVideoView.m",
         "objc/Framework/Classes/RTCNativeNV12Shader.mm",
         "objc/Framework/Headers/WebRTC/RTCEAGLVideoView.h",
       ]
       libs = [
         "CoreGraphics.framework",
@@ skipping 62 matching lines @@
         "objc/Framework/UnitTests/avformatmappertests.mm",
       ]
       if (is_ios) {
         sources += [ "objc/Framework/UnitTests/RTCMTLVideoViewTests.mm" ]
         if (current_cpu != "arm64") {
           sources += [ "objc/Framework/Classes/Metal/RTCMTLVideoView.m" ]
         }
       }
       deps = [
         ":rtc_sdk_peerconnection_objc",
+        "../base:rtc_base_tests_utils",
         "//third_party/ocmock",
         "//webrtc/system_wrappers:system_wrappers_default",
       ]
 
       # TODO(tkchin): Cleanup this warning.
       cflags = [ "-Wno-objc-property-no-attribute" ]
 
       # |-ObjC| flag needed to make sure category method implementations
       # are included:
       # https://developer.apple.com/library/mac/qa/qa1490/_index.html
@@ skipping 115 matching lines @@
       "objc/Framework/Classes/h264_video_toolbox_nalu.h",
     ]
 
     configs += [
       "//webrtc:common_objc",
       "//build/config/compiler:enable_arc",
     ]
 
     deps = [
       ":rtc_sdk_common_objc",
+      "../api:video_frame_api",
+      "../base:rtc_base_approved",
+      "../common_video:common_video",

[kjellander_webrtc, 2017/04/12 14:37:04]

Leave out :common_video here for improved readability. Same earlier in the file.

[mbonadei, 2017/04/13 08:12:03]

Done.

+      "../media:rtc_media_base",
+      "../modules/video_coding:video_coding_utility",
+      "../modules/video_coding:webrtc_h264",
+      "../system_wrappers:system_wrappers",

[kjellander_webrtc, 2017/04/12 14:37:04]

You can leave out the :system_wrappers part.

[mbonadei, 2017/04/13 08:12:03]

Done.

     ]
 
     libs = [
       "CoreFoundation.framework",
       "CoreMedia.framework",
       "CoreVideo.framework",
       "VideoToolbox.framework",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
 
     if (rtc_build_libyuv) {
       deps += [ "$rtc_libyuv_dir" ]
       public_deps = [
         "$rtc_libyuv_dir",
       ]
     } else {
       # Need to add a directory normally exported by libyuv.
       include_dirs = [ "$rtc_libyuv_dir/include" ]
     }
   }
 }