Chromium Code Reviews Chromium Code Reviews
Issue 2818433003:
Enabling 'gn check' on webrtc/sdk (Closed)
| Index: webrtc/sdk/android/BUILD.gn |
| diff --git a/webrtc/sdk/android/BUILD.gn b/webrtc/sdk/android/BUILD.gn |
| index 12ebb8358abffdb34e40dc73c177e747740cb80e..47e9f58141b27729af90799e65a94ed070f8cfb1 100644 |
| --- a/webrtc/sdk/android/BUILD.gn |
| +++ b/webrtc/sdk/android/BUILD.gn |
| @@ -67,6 +67,20 @@ rtc_static_library("libjingle_peerconnection_jni") { |
| } |
| deps = [ |
| + "../..:webrtc_common", |
| + "../../api:video_frame_api", |
| + "../../api/video_codecs:video_codecs_api", |
| + "../../base:rtc_base", |
| + "../../base:rtc_base_approved", |
| + "../../base:rtc_task_queue", |
| + "../../common_video:common_video", |
| + "../../media:rtc_media", |
| + "../../media:rtc_media_base", |
| + "../../modules/utility:utility", |
| + "../../modules/video_coding:video_coding_utility", |
| + "../../system_wrappers:field_trial_default", |
|
kjellander_webrtc
2017/04/12 14:37:04
Similar question here as before. I don't think we
mbonadei
2017/04/13 08:12:03
Answered on the other question.
|
| + "../../system_wrappers:system_wrappers", |
| + "../../voice_engine:voice_engine", |
| "//webrtc/pc:libjingle_peerconnection", |
| ] |
| @@ -89,6 +103,8 @@ rtc_static_library("libjingle_peerconnection_metrics_default_jni") { |
| configs += [ ":libjingle_peerconnection_jni_warnings_config" ] |
| deps = [ |
| + ":libjingle_peerconnection_jni", |
| + "../../system_wrappers:system_wrappers", |
|
kjellander_webrtc
2017/04/12 14:37:04
Leave out :system_wrappers
mbonadei
2017/04/13 08:12:03
Done.
|
| "//webrtc/pc:libjingle_peerconnection", |
| "//webrtc/system_wrappers:field_trial_default", |
| "//webrtc/system_wrappers:metrics_default", |
| @@ -106,6 +122,7 @@ rtc_shared_library("libjingle_peerconnection_so") { |
| deps = [ |
| ":libjingle_peerconnection_jni", |
| ":libjingle_peerconnection_metrics_default_jni", |
| + "../../base:rtc_base", |
| "//webrtc/pc:libjingle_peerconnection", |
| ] |
| output_extension = "so" |
