Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2816493002: Reland of Add content type information to encoded images and corresponding rtp extension header (Closed)

Created:
3 years, 8 months ago by ilnik
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, the sun, perkj_webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add content type information to encoded images and corresponding rtp extension header (patchset #1 id:1 of https://codereview.webrtc.org/2809653004/ ) Reason for revert: Fix failing bots. BUG=webrtc:7420 Review-Url: https://codereview.webrtc.org/2816493002 Cr-Commit-Position: refs/heads/master@{#17658} Committed: https://chromium.googlesource.com/external/webrtc/+/00d802b6ee72259b0f8a83865961afc26c0f7e1f

Patch Set 1 #

Patch Set 2 : fix failures on android #

Patch Set 3 : Fix failures on android pass 2 #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -99 lines) Patch
A + webrtc/api/video/video_content_type.h View 1 2 chunks +13 lines, -8 lines 0 comments Download
M webrtc/common_types.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/common_types.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/config.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/config.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 4 chunks +39 lines, -55 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/encoded_frame.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/encoded_frame.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/frame_object.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/include/mock/mock_vcm_callbacks.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/test/call_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/constants.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/constants.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/test/fuzzers/rtp_packet_fuzzer.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 chunks +114 lines, -1 line 0 comments Download
M webrtc/video/payload_router.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 5 chunks +41 lines, -7 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 2 chunks +18 lines, -10 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video_frame.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
ilnik
Created Reland of Add content type information to encoded images and corresponding rtp extension header
3 years, 8 months ago (2017-04-11 13:21:23 UTC) #1
tommi
On 2017/04/11 13:21:23, ilnik wrote: > Created Reland of Add content type information to encoded ...
3 years, 8 months ago (2017-04-11 14:00:46 UTC) #11
ilnik
On 2017/04/11 14:00:46, tommi (wëbrtc) wrote: > On 2017/04/11 13:21:23, ilnik wrote: > > Created ...
3 years, 8 months ago (2017-04-11 14:17:04 UTC) #13
tommi
lgtm
3 years, 8 months ago (2017-04-11 14:36:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2816493002/340001
3 years, 8 months ago (2017-04-11 17:31:32 UTC) #27
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:34:39 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:340001) as
https://chromium.googlesource.com/external/webrtc/+/00d802b6ee72259b0f8a83865...

Powered by Google App Engine
This is Rietveld 408576698