|
Reland of Add content type information to encoded images and corresponding rtp extension header (patchset #1 id:1 of https://codereview.webrtc.org/2816463002/ )
Reason for revert:
Reland with appropriate changes to API to not break depending projects.
Original issue's description:
> Revert of Add content type information to encoded images and corresponding rtp extension header (patchset #31 id:600001 of https://codereview.webrtc.org/2772033002/ )
>
> Reason for revert:
> Breaks dependent projects.
>
> Original issue's description:
> > Add content type information to Encoded Images and add corresponding RTP extension header.
> > Use it to separate UMA e2e delay metric between screenshare from video.
> > Content type extension is set based on encoder settings and processed and decoders.
> >
> > Also,
> > Fix full-stack-tests to calculate RTT correctly, so new metric could be tested.
> >
> > BUG= webrtc:7420
> >
> > Review-Url: https://codereview.webrtc.org/2772033002
> > Cr-Commit-Position: refs/heads/master@{#17640}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/64e739aeae5629cbbebf2a19e1d3e6b452bb6d0b
>
> TBR=tommi@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= webrtc:7420
>
> Review-Url: https://codereview.webrtc.org/2816463002
> Cr-Commit-Position: refs/heads/master@{#17644}
> Committed: https://chromium.googlesource.com/external/webrtc/+/57218668083fce36a55efb8c8f1d31785253b8c0
TBR=tommi@webrtc.org,sprang@webrtc.org,stefan@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= webrtc:7420
Review-Url: https://codereview.webrtc.org/2812913002
Cr-Commit-Position: refs/heads/master@{#17651}
Committed: https://chromium.googlesource.com/external/webrtc/+/774f6b4b968b46d6bd95c42eec0ce3202b47f0b2
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+460 lines, -99 lines) |
Patch |
 |
A + |
webrtc/api/video/video_content_type.h
|
View
|
1
|
2 chunks |
+13 lines, -8 lines |
0 comments
|
Download
|
 |
M |
webrtc/common_types.h
|
View
|
1
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/common_types.cc
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/config.h
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/config.cc
|
View
|
1
|
2 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/media/engine/webrtcvideoengine2_unittest.cc
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/include/module_common_types.h
|
View
|
1
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_header_extension.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h
|
View
|
1
|
2 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc
|
View
|
1
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_packet.cc
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc
|
View
|
1
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
|
View
|
1
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/rtp_rtcp/source/rtp_utility.cc
|
View
|
1
|
2 chunks |
+23 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_capture/video_capture_impl.cc
|
View
|
1
|
4 chunks |
+39 lines, -55 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/encoded_frame.h
|
View
|
1
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/encoded_frame.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/frame_buffer.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/frame_object.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/generic_decoder.h
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/generic_decoder.cc
|
View
|
1
|
3 chunks |
+12 lines, -2 lines |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/include/mock/mock_vcm_callbacks.h
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/modules/video_coding/include/video_coding_defines.h
|
View
|
1
2
3
|
1 chunk |
+10 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm
|
View
|
1
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/test/call_test.cc
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/test/constants.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/test/constants.cc
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/test/fake_encoder.cc
|
View
|
1
|
3 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/test/fuzzers/rtp_packet_fuzzer.cc
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/end_to_end_tests.cc
|
View
|
1
|
2 chunks |
+114 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/video/payload_router.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/receive_statistics_proxy.h
|
View
|
1
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/receive_statistics_proxy.cc
|
View
|
1
|
5 chunks |
+41 lines, -7 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/receive_statistics_proxy_unittest.cc
|
View
|
1
|
2 chunks |
+18 lines, -10 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/rtp_stream_receiver.cc
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/video_quality_test.cc
|
View
|
1
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/video_send_stream_tests.cc
|
View
|
1
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
 |
M |
webrtc/video/video_stream_decoder.h
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
webrtc/video/video_stream_decoder.cc
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
webrtc/video_frame.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 13 (7 generated)
|